Using Mod in an Abstract Syntax Tree Haskell

Question

I am having trouble with the Mod operator in Haskell Its inferring the wrong type based on what I have. Mod is at the bottom of eval. I am new to Haskell and am making an AST with expr for class. Here is the code I have so far. I am sure its a simple fix but cant seem to get it.

data Expr = Add Expr Expr
      | Sub Expr Expr
      | Mult Expr Expr
      | EqualTo Expr Expr
      | GreaterThan Expr Expr
      | LessThan Expr Expr
      | Mod Expr
      | NotEqual Expr Expr

      | Const Integer
      | VarName String
      | TrueE
      | FalseE
  deriving (Show,Eq) 


eval :: Expr -> [(String, Integer)] -> Integer
eval (Add e1 e2) env = eval e1 env + eval e2 env
eval (Sub e1 e2) env = eval e1 env - eval e2 env
eval (Mult e1 e2) env = eval e1 env * eval e2 env
eval (EqualTo e1 e2) env | eval e1 env == eval e2 env = 1
                     | otherwise = 0 
eval (GreaterThan e1 e2) env | eval e1 env > eval e2 env = 1
             | otherwise = 0    
eval (LessThan e1 e2) env | eval e1 env < eval e2 env = 1
          | otherwise = 0
eval (NotEqual e1 e2) env | eval e1 env /= eval e2 env = 1
                      | otherwise = 0
eval (Mod e1) env =  mod eval e1 env

kimhyunkang · Accepted Answer · 2012-11-28 06:20:03Z

2

I assume that you are building an evaluator for AST, which represents a mathematical expression.

Haskell function mod receives two arguments, but your AST receives only one argument, and function mod in your evaluator receives three arguments. Try to change the function eval and data Expr like this

data Expr =
   | Mod Expr Expr

eval :: Expr -> [(String, Integer)] -> Integer
eval (Mod e1 e2) env = mod (eval e1 env) (eval e2 env)

In the above code, function mod receives two arguments, eval e1 env and eval e2 env respectively.

answered Nov 28, 2012 at 6:20

kimhyunkang

1556 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

AndrewC · Accepted Answer · 2012-11-28 06:55:57Z

0

I was using the wrong notation for mod it should be

eval e1 env `mod` eval e2 env

Stupid mistake.. mod should be surrounded by back ticks.

edited Nov 28, 2012 at 6:55

AndrewC

32.5k7 gold badges81 silver badges115 bronze badges

answered Nov 28, 2012 at 6:17

Ben Fossen

1,0078 gold badges24 silver badges48 bronze badges

Collectives™ on Stack Overflow

Using Mod in an Abstract Syntax Tree Haskell

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related