Java time Error converting data

Question

I have a little problem with the translation of this data 19/12/2005 17:30:45 to mileseconds. I don't know why, I am getting a wrong translation to Jun 28 17:30:45 CEST 1995 Time :804353445798

The code I used is this :

private static long ConvertTimeToTimeStamp(String time) {   

  Integer[] data = new Integer[6];
  String [] tokens = time.split(" "); 

  System.out.println(tokens[0]);
  System.out.println(tokens[1]);

  String[] d_m_y = tokens[0].split("/"); 
  String[] hh_mm_ss = tokens[1].split(":"); 

  for (int i = 0; i < d_m_y.length; i++) {
    data[i]=Integer.parseInt(d_m_y[i]); 
    // System.out.println(d_m_y[i]);        
  }

  for (int i = 0; i < hh_mm_ss.length; i++) {
    data[i+3]=Integer.parseInt(hh_mm_ss[i]); 
    //  System.out.println(hh_mm_ss[i]);    
  }
  //Calendar calendar =  Calendar.getInstance(); 
  GregorianCalendar calendar = new GregorianCalendar(); 
  calendar.set(data[0]+1970, data[1], data[2], data[3],data[4],data[5]);

  System.out.println(calendar.getTime().toString()); 
  return calendar.getTimeInMillis(); 
}

assylias · Accepted Answer · 2012-11-30 12:09:25Z

6

You should not parse the date manually - use a date format instead:

String s = "19/12/2005 17:30:45";
Date d = new SimpleDateFormat("dd/MM/yyyy HH:mm:ss").parse(s);

answered Nov 30, 2012 at 12:09

assylias

330k84 gold badges680 silver badges806 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Brian Agnew · Accepted Answer · 2012-11-30 12:08:43Z

2

Treat this object from the outset as a date. That will be much more reliable.

Use SimpleDateFormat.parse() to parse your string into a date/time. Otherwise you're reduced to string parsing/splitting/recombining etc with no bounds-checking, type-checking etc. Your solution is stringly-typed, not strongly-typed.

I've referenced the standard Java libraries, but Joda-Time is a better bet for doing date work in Java and I would advise adopting this for a more intuitive and safer API.

answered Nov 30, 2012 at 12:08

Brian Agnew

273k38 gold badges342 silver badges443 bronze badges

1 Comment

Perception Over a year ago

'stringly-typed'? You sir, get a cookie!

SJuan76 · Accepted Answer · 2012-11-30 12:09:47Z

1

Forget about it. Use a SimpleDataFormat object with pattern dd/MM/yyyy HH:mm:ss to parse() the String into a date object.

answered Nov 30, 2012 at 12:09

SJuan76

24.9k7 gold badges52 silver badges95 bronze badges

Comments

Aditya Jain · Accepted Answer · 2012-11-30 12:12:34Z

1

try...

private static long ConvertTimeToTimeStamp(String time) { 
   //19/12/2005 17:30:45
   SimpleDateFormat sdf = new SimpleDateFormat("dd/MM/yyyy hh:mm:ss");
   java.util.Date d = sdf.parse(time);
   return d.getTime();
}

answered Nov 30, 2012 at 12:12

Aditya Jain

1,0951 gold badge12 silver badges25 bronze badges

Comments

Stephan · Accepted Answer · 2012-11-30 12:09:00Z

0

You are mixing the order of year, month and day. The set method is expecting them in the following order: year, month, day and you are providing them as day + 1970, month, year. Having said that, you might actually be much more happy with a library like joda-time.

answered Nov 30, 2012 at 12:09

Stephan

7,38839 silver badges46 bronze badges

Collectives™ on Stack Overflow

Java time Error converting data

5 Answers 5

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related