Passing parameters to onchange doesnt use the parameters at runtime

Question

Hello I am using function

function prepareRadios(radioGroupName) {
  var radios = document.getElementsByName(radioGroupName);
  for( i = 0; i < radios.length; i++ ) {
    document.getElementById(radios[i].id).onchange = function() {
      radioUpdated(radioGroupName, radios[i].id); 
    };
  }
}

the problem is, that the onchange event fires with quote (radioGroupName, radios[i].id) instead of having those values put into it with my function

I need to pass the VALUES of them, not the names of the vars

What am I doing wrong?

Community · Accepted Answer · 2017-05-23 10:24:44Z

2

It's closure-time :)

function prepareRadios(radioGroupName) {
    var radios = document.getElementsByName(radioGroupName);
    for( i = 0; i < radios.length; i++ ) {
        document.getElementById(radios[i].id).onchange = (function(name, id) {
            return function() { radioUpdated(name, id); }
        })(radioGroupName, radios[i].id);
    }
}

edited May 23, 2017 at 10:24

CommunityBot

11 silver badge

answered Nov 30, 2012 at 14:46

Andreas

21.9k7 gold badges52 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Passing parameters to onchange doesnt use the parameters at runtime

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related