Add argument off function to string in javascript

Question

I want to add an argument of a function to a string (iam not sure if thats the right word)

function changeChart(form, chart, bar) {

            //chart 2 (left)
            $(form).change(function (){

                console.log(form);

                $(form + "option:selected").each(function(){
                //rest of the function

I want the form added to the selection in Jquery.

Is this the right way?

What does form look like? Is it the actual object, such as $('#myForm'), or is it a string representation of the selector, such as #myForm? — Ohgodwhy
– Ohgodwhy, Commented Nov 30, 2012 at 17:04

I Hate Lazy · Accepted Answer · 2012-11-30 17:10:47Z

4

If form is a string, you need to be sure there's a space before "option:selected".

$(form + " option:selected").each(function(){

If form is an element, pass it to the jQuery functin, then use find:

$(form).find("option:selected").each(function(){

Or use the context parameter (though IMO the code is less clear):

$("option:selected", form).each(function(){

Although, since you're in the handler, you could just use this to reference the form element.

$(this).find("option:selected").each(function(){

edited Nov 30, 2012 at 17:10

answered Nov 30, 2012 at 17:04

I Hate Lazy

49k13 gold badges89 silver badges79 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Ohgodwhy Over a year ago

$(form).find("option:selected") should be $('option:selected', form) in this scenario.

I Hate Lazy Over a year ago

@Ohgodwhy: I added that, but why do you say it "should be"? It's a little less efficient to add form as the context.

adeneo Over a year ago

@Ohgodwhy - does'nt matter, the latter is just a shortcut for the former. On the other hand inside the function it would be better to use this in the context .

Sushanth -- · Accepted Answer · 2012-11-30 17:05:30Z

0

If form is a string that corresponds to an ID

Then it's supposed to be

$('#' + form)

$('#' + form + " option:selected")

If its a class replace # with a .

answered Nov 30, 2012 at 17:05

Sushanth --

55.8k9 gold badges70 silver badges109 bronze badges

Collectives™ on Stack Overflow

Add argument off function to string in javascript

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related