Php Mysql Search Issue

Question

I'm trying create a simple search script with php and mysql. I've html select tag which is

people
country
region
destination
from
to

With this I get the content from from mysql database. so following is my php script.

if(isset($_GET['Submit']) && $_GET['Submit'] == "Search")
{
$people = mysql_real_escape_string(htmlspecialchars(trim($_GET['people'])));
$country =  mysql_real_escape_string(htmlspecialchars(trim($_GET['country'])));
$region =  mysql_real_escape_string(htmlspecialchars(trim($_GET['region-depart'])));
$destination = mysql_real_escape_string(htmlspecialchars(trim($_GET['destination'])));
$from = mysql_real_escape_string(htmlspecialchars(trim($_GET['from'])));
$to = mysql_real_escape_string(htmlspecialchars(trim($_GET['to'])));

if(isset($people))
{

$search = mysql_query("SELECT * FROM property_step1 WHERE pro_no_sleep LIKE 
'%$people%'");
$num = mysql_num_rows($search);

while($result = mysql_fetch_array($search))
    {
        $propertyid = (int) $result['propertyid'];          
        echo $country_d = $result['pro_country'];
        echo $region_d = $result['pro_state'];
        echo $destination_d = $result['pro_city'];

    }
}

elseif(isset($country))
{
$search2 = mysql_query("SELECT * FROM property_step1 WHERE pro_country LIKE 
'%$country%'");
$num = mysql_num_rows($search2);        

while($result2 = mysql_fetch_array($search2))
    {
        $propertyid = (int) $result2['propertyid'];         
        echo $country_d = $result2['pro_country'];
        echo $region_d = $result2['pro_state'];
        echo $destination_d = $result2['pro_city'];

    }
}
else
{
    echo "nope";
}       
}

Well, if i select people (which value is 1, 2, 3 and so on) it's show the content from database but when i select country it's doesn't show anything. Is there anything wrong in my query?

By any chance can you share your mysql tables with us?

bonCodigo
– bonCodigo

2012-12-01 15:01:34 +00:00
Commented Dec 1, 2012 at 15:01 — bonCodigo
– bonCodigo, Commented Dec 1, 2012 at 15:01

Isaac · Accepted Answer · 2012-12-01 15:09:18Z

1

isset($people) always evaluates to true; you need to check if it is not empty as well:

if (isset($people) && !empty($people)) {
    // ...
}

edited Dec 1, 2012 at 15:09

answered Dec 1, 2012 at 15:03

Isaac

2,7214 gold badges34 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pankaj Khairnar · Accepted Answer · 2012-12-01 15:08:30Z

Your elseif condition for country is creating problem replace it with if only, writing if...elseif only one condition will get execute.

use this code

if (isset($_GET['Submit']) && $_GET['Submit'] == "Search") {
    $people = mysql_real_escape_string(htmlspecialchars(trim($_GET['people'])));
    $country = mysql_real_escape_string(htmlspecialchars(trim($_GET['country'])));
    $region = mysql_real_escape_string(htmlspecialchars(trim($_GET['region-depart'])));
    $destination = mysql_real_escape_string(htmlspecialchars(trim($_GET['destination'])));
    $from = mysql_real_escape_string(htmlspecialchars(trim($_GET['from'])));
    $to = mysql_real_escape_string(htmlspecialchars(trim($_GET['to'])));

    if (isset($people)) {
        $search = mysql_query("SELECT * FROM property_step1 WHERE pro_no_sleep LIKE 
'%$people%'");
        $num = mysql_num_rows($search);

        while ($result = mysql_fetch_array($search)) {
            $propertyid = (int) $result['propertyid'];
            echo $country_d = $result['pro_country'];
            echo $region_d = $result['pro_state'];
            echo $destination_d = $result['pro_city'];
        }
    } 
    if (isset($country)) {
        $search2 = mysql_query("SELECT * FROM property_step1 WHERE pro_country LIKE 
'%$country%'");
        $num = mysql_num_rows($search2);

        while ($result2 = mysql_fetch_array($search2)) {
            $propertyid = (int) $result2['propertyid'];
            echo $country_d = $result2['pro_country'];
            echo $region_d = $result2['pro_state'];
            echo $destination_d = $result2['pro_city'];
        }
    } else {
        echo "nope";
    }
}

Samuel Cook · Accepted Answer · 2012-12-01 15:20:40Z

0

You are defining each variable so all variables will always "be set".

if(isset($people)) will always run, as it is defined meaning that isset($country) will never run.

This needs to be changed to:

if(!empty($people)){

}
if(!empty($country)){

}

edited Dec 1, 2012 at 15:20

answered Dec 1, 2012 at 15:04

Samuel Cook

16.9k7 gold badges56 silver badges65 bronze badges

6 Comments

Samuel Cook Over a year ago

it should achieve what your looking for

Babu Over a year ago

I change it. it's show first query but it's doesn't show second query.. It's show empty page

Samuel Cook Over a year ago

do you always need it to run people AND country? If so you need to remove the else in the elseif statement.

Babu Over a year ago

Well, I put elseif statement because sometime user can select only people or country or destination so if user select only 1 item then it's show something base on his selected item.

Babu Over a year ago

I removed else but doesn't show anything only first query is running.

|

Collectives™ on Stack Overflow

Php Mysql Search Issue

3 Answers 3

Comments

Comments

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related