OutOfMemoryError while converting Stream to String in Android

Question

am loading xml file from Assets folder. am getting OutOfMemoryError. The code which i have used is

private String convertStreamToString(InputStream is) {  
    BufferedReader reader = new BufferedReader(new InputStreamReader(is));
    StringBuilder sb = new StringBuilder();

    String line = null;
    try {
        while ((line = reader.readLine()) != null) {
            sb.append(line + NEW_LINE);
        }
        reader.close();

    } catch (IOException e) {
        //do nothing.
    } finally {
        try {
            reader.close();
        } catch (IOException e) {
            //do nothing.    
        }
    }
    reader=null;
    return sb.toString();
}

Is there an alternate way to get rid of this Exception. It will be more helpful if you post any code. Thanks in advance.

You may read one line from the XML file, process it, and continue to the next line. Don't read the whole file into memory, the file may be very large. — Jason Kuang
– Jason Kuang, Commented Dec 4, 2012 at 6:47

Snicolas · Accepted Answer · 2012-12-04 06:50:43Z

3

It's not a good idea to parse a big Xml using a String. You should turn to a streaming version of the parser. Google Http Java Client proposes such a library : http://code.google.com/p/google-http-java-client

answered Dec 4, 2012 at 6:50

Snicolas

38.2k15 gold badges118 silver badges177 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nirav Tukadiya · Accepted Answer · 2012-12-04 06:56:07Z

0

put line=null; in while loop after appending to sb.

edited Dec 4, 2012 at 6:56

answered Dec 4, 2012 at 6:50

Nirav Tukadiya

3,4271 gold badge20 silver badges36 bronze badges

1 Comment

Nirav Tukadiya Over a year ago

and sorry to put this as answer because i can not comment at other's post.

sravan · Accepted Answer · 2013-07-08 08:15:44Z

0

try Below

Have you tried the built in method to convert a stream to a string? It's part of the Apache Commons library (org.apache.commons.io.IOUtils).

Then your code would be this one line:

String total = IOUtils.toString(inputStream);

The documentation for it can be found here: http://commons.apache.org/io/api-1.4/org/apache/commons/io/IOUtils.html#toString%28java.io.InputStream%29

The Apache Commons IO library can be downloaded from here: http://commons.apache.org/io/download_io.cgi

answered Jul 8, 2013 at 8:15

sravan

5,3311 gold badge33 silver badges33 bronze badges

2 Comments

KMI Over a year ago

Can you guide me how to use this one? am little bit confused.

sravan Over a year ago

you have to Add External Library

Collectives™ on Stack Overflow

OutOfMemoryError while converting Stream to String in Android

3 Answers 3

Comments

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related