Java script || or operator condition is not working

Question

In the below script I added or operator to check the condition, Like if it is "ALL TCP" or "ALL UDP" item must get disabled, Please suggest me to modify the code.

<script type="text/javascript">
    function chgJob(pThis, pRow)
    {
        if ((pThis.value != 'All TCP') || (pThis.value != 'All UDP'))
        {
            $x_disableItem('f02_' + pRow, false);
        }
        else
        {
            $x_disableItem('f02_' + pRow, true);
        }
    }
</script>

if ((pThis.value != 'All TCP') || (pThis.value != 'All UDP')) can also be written as if ((pThis.value == 'All TCP') && (pThis.value == 'All UDP')) — Simon Laing
– Simon Laing, Commented Dec 4, 2012 at 7:36
@SimonLaing: Incorrect. Your and statement will always return false, since pThis.value can't possibly be 'All TCP' and 'All UDP' a the same time. — Cerbrus
– Cerbrus, Commented Dec 4, 2012 at 7:47

Guffa · Accepted Answer · 2012-12-04 08:47:59Z

4

A string can never be equal to 'All TCP' and equal to 'All UDP' at the same time, so the condition will always be true.

You want to use the && operator instead of the || operator:

if ((pThis.value != 'All TCP') && (pThis.value != 'All UDP'))

Edit:

As Cerbrus pointed out, you don't need the if statement at all, you can use the boolean expression directly by inverting it (x==y || x==z is the same as !(x!=y && x!=z)):

<script type="text/javascript">
function chgJob(pThis, pRow) {
    $x_disableItem('f02_' + pRow, pThis.value == 'All TCP' || pThis.value == 'All UDP');
}
</script>

edited Dec 4, 2012 at 8:47

answered Dec 4, 2012 at 7:30

Guffa

703k111 gold badges760 silver badges1k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Cerbrus Over a year ago

Since you've got the most votes already, would you want to add my suggestion about omitting the if-else altogether?

dencey · Accepted Answer · 2012-12-04 07:37:15Z

0

try this:

if ((pThis.value != 'All TCP') && (pThis.value != 'All UDP'))

or :

function chgJob(pThis, pRow)
{
    if ((pThis.value == 'All TCP') || (pThis.value == 'All UDP'))
    {
        $x_disableItem('f02_' + pRow, true);
    }
    else
    {
        $x_disableItem('f02_' + pRow, false);
    }
}

answered Dec 4, 2012 at 7:37

dencey

1,06117 silver badges26 bronze badges

Comments

Cerbrus · Accepted Answer · 2012-12-04 07:45:04Z

0

Like has been said already, in your if-else, you'll need the && operator, instead of the ||, but:

You can also remove the if altogether, by doing this instead:

function chgJob(pThis, pRow) {
    $x_disableItem('f02_' + pRow, (pThis.value == 'All TCP' || pThis.value == 'All UDP'));
}

If pThis.value is "ALL TCP" or "ALL UDP", the item will be disabled.

answered Dec 4, 2012 at 7:45

Cerbrus

73.3k19 gold badges138 silver badges151 bronze badges

Collectives™ on Stack Overflow

Java script || or operator condition is not working

3 Answers 3

Edit:

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Edit:

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related