Issues with JavaScript settimeout function

Question

I am very new to JavaScript and cannot seem to get the setTimeout command to do anything. I know this has been asked many times before, but I have spent the last two hours looking at all previous cases of it and it still isn't working for me. Here is what I have got at the moment:

<html>
    <script type="text/javascript">

    var i = 0;
    function aloop() {
        document.write(i);
        i++;
    }

    function afunction() {
        if (i <= 12) {
            setTimeout(aloop(), 1000);
            afunction();
        }
    }

    </script>

    <form>
    <input type=submit value="Click me!" onClick="afunction()">
</html>

Can anyone tell me what I should do to make this work?

In addition to the answers, look into using a regular for loop. — Justin Self
– Justin Self, Commented Dec 6, 2012 at 20:55

Quentin · Accepted Answer · 2012-12-06 20:53:10Z

4

Pass a function to setTimeout, not the return value of a function call.

setTimeout(aloop,1000);

answered Dec 6, 2012 at 20:53

Quentin

949k136 gold badges1.3k silver badges1.4k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Eli Gassert · Accepted Answer · 2012-12-06 20:53:25Z

1

The problem is you're calling your function instead of queuing your function.

setTimeout(aloop, 1000) NOT setTimeout(aloop(), 1000);

answered Dec 6, 2012 at 20:53

Eli Gassert

9,7713 gold badges33 silver badges40 bronze badges

Comments

I Hate Lazy · Accepted Answer · 2012-12-06 21:05:19Z

1

You didn't describe what doesn't work, but I'll assume you want the i to be written in 1000 millisecond intervals.

Do this:

<html>
 <!-- you're missing your head tags -->

<head>
    <title> my page </title>

    <script type="text/javascript">
    var i=0;
    function aloop() {
          // don't use document.write after the DOM is loaded
        document.body.innerHTML = i;
        i++;
        afunction(); // do the next call here
    }
    function afunction() {
        if (i<=12) {
                 //     v---pass the function, don't call
            setTimeout(aloop,1000);

      //    afunction();  // remove this because it'll call it immediately
        }
    }
    </script>
</head>

<!-- you're missing your body tags -->
<body>
    <form>
        <input type=submit value="Click me!" onClick="afunction()">
    </form> <!-- you're missing your closing form tag --> 
</body>
</html>

edited Dec 6, 2012 at 21:05

answered Dec 6, 2012 at 20:59

I Hate Lazy

49k13 gold badges89 silver badges79 bronze badges

1 Comment

user1883633 Over a year ago

Thanks everyone for all your help. It's working as I want it to now.

Collectives™ on Stack Overflow

Issues with JavaScript settimeout function

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related