CheckBox handling oncheck changed in ASP.net

Question

i had a DataList view which i add a check box in the Item Template

i want each item i select to increase some counter for examble once it's checked .. i used the following code to handle that ,but the event function is never accessed ?!

    protected void selectItemCheckBox_CheckedChanged(object sender, EventArgs e)
    {        
    int selected = 0;
    foreach (DataListItem i in DataList1.Items)
    {
        CheckBox chk = (CheckBox)i.FindControl("selectItemCheckBox");
        if (chk.Checked)
        {

            selected++;
        }
        selectedItemCount.Text = Convert.ToString(selected);
        }`
     }

Did you make AutoPostBack="True"? msdn.microsoft.com/en-us/library/… — Win
– Win, Commented Dec 7, 2012 at 15:07
Have you assigned the event handler to the control? <asp:CheckBox id="selectItemCheckBox" runat="server" OnCheckedChanged="selectItemCheckBox_CheckedChanged" /> — Richard Deeming
– Richard Deeming, Commented Dec 7, 2012 at 15:21

Kirk · Accepted Answer · 2012-12-07 16:45:42Z

Currently you're looping over every checkbox for every checked checkbox which is inefficient and depending on your other code, may be causing trouble.

You're better off incrementing for each checkbox individually.

...DataList...
<ItemTemplate>
    <asp:CheckBox id="selectItemCheckBox" runat="server"
        AutoPostBack="True"
        OnCheckedChanged="selectItemCheckBox_CheckedChanged" />
</ItemTemplate>
...DataList...

After a box is checked, update the total for just that checkbox using sender

protected void selectItemCheckBox_CheckedChanged(object sender, EventArgs e)
{
    // Parse the total selected items from the TextBox.
    // You may consider using a Label instead, or something non-editable like a hidden field
    int totalChecked;
    if (int.TryParse(selectedItemCount.Text, out totalChecked) = false)
        totalChecked = 0;

    // Get a reference to the CheckBox
    CheckBox selectItemCheckBox = (CheckBox)sender;

    // Increment the total
    if (selectItemCheckBox.Checked == true)
        totalChecked++;

    // Put back in the TextBox
    selectedItemCount.Text = totalChecked.ToString();
}

Collectives™ on Stack Overflow

CheckBox handling oncheck changed in ASP.net

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related