Convert files into string array C++

Question

I need to read a file and turn it into a string array but when it reads the file it doesn't put anything in the array. Here's my current code:

string code[200];
string name;
int lines;
string filename;
int readfile(){
  ifstream inFile;
  int counter = 0;
  cout << "Which file would you like to open?\n";
  cin >> filename;
  countlines();//counts total lines of file
  inFile.open(filename);
  if(inFile.fail())
  {
    cout << "File did not open correctly, please check it\n";
    system("pause");
    exit(0);
    //return 1;
  }
  inFile >> name;
  for (int i=0;i < lines; i++)
  {
    inFile >> code[i];
    if (!inFile)
      cout << "Error" << endl;
    break;
  }
  inFile.close();
  cout << "Now opened: " << name << endl;
  return 0;
}

"Not working" is a very vague description.

Qaz
– Qaz

2012-12-09 02:26:42 +00:00
Commented Dec 9, 2012 at 2:26 — Qaz
– Qaz, Commented Dec 9, 2012 at 2:26
What's the filename you're inputting?

irrelephant
– irrelephant

2012-12-09 02:32:35 +00:00
Commented Dec 9, 2012 at 2:32 — irrelephant
– irrelephant, Commented Dec 9, 2012 at 2:32

Jonathan Vukovich-Tribouharet · Accepted Answer · 2012-12-09 03:16:50Z

1

#include <vector>
#include <string>
#include <fstream>
#include <iostream>

using namespace std;

vector<string> lines;

bool readFile(string filename){
    ifstream file;
    string line;

    file.open(filename.c_str());

    if(!file.is_open()){
        return false;
    }

    while (getline(file, line)) {
        lines.push_back(line);
    }

    return true;
}


int main(){
    readFile("test.txt");

    for(int i = 0; i < lines.size(); ++i){
        cout << lines[i] << endl;
    }

    return 0;
}

edited Dec 9, 2012 at 3:16

answered Dec 9, 2012 at 2:47

Jonathan Vukovich-Tribouharet

1,98814 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user1858143 Over a year ago

How can I use lines in a for loop? for(int i = 0; i < lines; i++){} isn't working

Jonathan Vukovich-Tribouharet Over a year ago

for(int i = 0; i < lines.size(); ++i){ cout << lines[i] << endl;} and include <iostream>, i update the code.

user1858143 Over a year ago

Thank you! This works great, this has been bothering me all day!

Krzysztof Kosiński · Accepted Answer · 2012-12-09 02:40:45Z

0

This is a much simpler implementation of line reading which doesn't crash if the file has more than 200 lines:

vector<string> code;
string s;
while (getline(inFile, s)) {
    code.push_back(s);
}

answered Dec 9, 2012 at 2:40

Krzysztof Kosiński

4,3652 gold badges21 silver badges24 bronze badges

Comments

jordan · Accepted Answer · 2012-12-09 02:56:18Z

0

You need to change

inFile.open(filename);

to:

inFile.open(filename.c_str());

answered Dec 9, 2012 at 2:56

jordan

11k10 gold badges47 silver badges81 bronze badges

2 Comments

Benjamin Lindley Over a year ago

Probably not. In C++11, ifstream and ofstream allow you to pass in std::string for filenames. Modern implementations support this feature. Considering he didn't mention a compiler error, it's a safe bet that his compiler supports it too.

jordan Over a year ago

@BenjaminLindley True. He didn't mention that. I only offered that since my g++ compiler wouldn't compile the code with std::string as the parameter value.

Collectives™ on Stack Overflow

Convert files into string array C++

3 Answers 3

3 Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related