ASP.NET MVC ActionLink Issue with Custom Routes

Question

I've been trying to get a couple of custom routes working with no luck. I have two pages for my automotive app. The first page shows a list of vehicles. When the user clicks the links generated on this page it takes them to the product list page. The problem is this page doesn't generate the links properly.

Here is the routes:

            routes.MapRoute(
                "Select_Vehicle",
                "Select_Vehicle/{id}/{make}",
                new { controller = "Select_Vehicle", action = "Index", id = UrlParameter.Optional, make = UrlParameter.Optional });

            routes.MapRoute(
                "Products",
                "Products/{id}/{make}/{model}",
                new { controller = "Products", action = "Index", id = UrlParameter.Optional, make = UrlParameter.Optional, model = UrlParameter.Optional });

            routes.MapRoute(
                "Default",
                "{controller}/{action}/{id}",
                new { controller = "Home", action = "Index", id = UrlParameter.Optional });

The Select_Vehicle page should generate links like this:

/products/horns/dodge/dakota

but what I get is this:

/Products/Index/horns?make=dodge&model=Dakota

It just doesn't work properly. Also, I don't understand why "Index" also shows since it is the default.

I've tried both ActionLink and RouteLink:

@Html.RouteLink(model, new { Controller = "Products", id = Model.CategoryName, make = Model.CurrentMake, model = model })
@Html.ActionLink(model, "Index", "Products", new { id = Model.CategoryName, make = Model.CurrentMake, model = model }, null)

This is driving me crazy.

Do you have anything else in your route?

Jack
– Jack

2012-12-10 11:30:48 +00:00
Commented Dec 10, 2012 at 11:30 — Jack
– Jack, Commented Dec 10, 2012 at 11:30

tvanfosson · Accepted Answer · 2012-12-10 01:09:03Z

2

ASP.NET MVC only supports a single optional parameter. Update your routes to give make and model a default rather than making them optional. You might also need to use the overload on RouteLink that takes the route name so that it chooses the correct route.

@Html.RouteLink(model, "Products", new 
 {
     id = Model.CategoryName,
     make = Model.CurrentMake,
     model = model
 })

answered Dec 10, 2012 at 1:09

tvanfosson

534k102 gold badges703 silver badges801 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jack · Accepted Answer · 2012-12-10 11:28:56Z

0

Your code should work. I've tested your routes with a fresh project and this is what I got. Do you have anything else in your route configuration?

http://localhost:60599/Products/horns/dodge/dakota

I am using asp.net MVC 3

edited Dec 10, 2012 at 11:28

answered Dec 10, 2012 at 11:08

Jack

2,66025 silver badges30 bronze badges

Comments

vincentw56 · Accepted Answer · 2012-12-13 02:18:13Z

0

Well, I figured out the problem. You can have more than one UrlParameter.Optional, but there is an issue. It is a bug or feature depending on how Microsoft wants to position it.

The issue is the the make was empty which caused a problem when it was building the URL. You can find more information here:

http://haacked.com/archive/2011/02/20/routing-regression-with-two-consecutive-optional-url-parameters.aspx

Thanks for all the suggestions and help.

answered Dec 13, 2012 at 2:18

vincentw56

5458 silver badges19 bronze badges

Collectives™ on Stack Overflow

ASP.NET MVC ActionLink Issue with Custom Routes

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related