Error when compare value in array using javascript?

Question

I have a sample code:

var find = ['iphone 3', 'iphone 4', 'iphone 5'];
var search = 'iphone 5';
for(i=0; i<find.length; i++) {
   if(search == find[i]) {
      alert('Yes');
   } else {
      alert('No');
   }
}

When I run code, result 2 alert(alert('Yes') and alert('No')), but result exactly is only a alert('Yes'), how to fix it ?

This seems to be working completely fine. Two Nos followed by one Yes. — Yogendra Singh
– Yogendra Singh, Commented Dec 10, 2012 at 1:52
@YogendraSingh: I think the OP doesn't want the "no"'s to show — Elias Van Ootegem
– Elias Van Ootegem, Commented Dec 10, 2012 at 1:55
@YogendraSingh: So I see, it's pretty much exactly the same as I answered. Also: no need for the present var in your anser, just if (i < find.length) will work: you're using a break statement, if that break is never encountered, i === find.length, else, it'll always be smaller. nitpicking, I know, but I like to use as little vars as possible — Elias Van Ootegem
– Elias Van Ootegem, Commented Dec 10, 2012 at 2:03

Elias Van Ootegem · Accepted Answer · 2012-12-10 01:54:08Z

1

If I understand your question correctly, you don't want no to be alerted when there is no match found:

var find = ['iphone 3', 'iphone 4', 'iphone 5'];
var search = 'iphone 5';
for(i=0; i<find.length; i++)
{
    if(search == find[i])
    {
       alert('Yes');
       break;//stop loop, found match
    }
}

Just don't provide the else branch. Oh, and if you don't care about older browsers:

if (find.indexOf(search) !== -1)
{
    alert('yes');
}

answered Dec 10, 2012 at 1:54

Elias Van Ootegem

76.7k10 gold badges123 silver badges160 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

David G · Accepted Answer · 2012-12-10 01:51:14Z

1

This can be done simply with .indexOf:

if ( find.indexOf( search ) > -1 ) {

    alert('Yes');

} else {

    alert('No');

}

Replace this with the entirety of your code excluding the variable declarations.

answered Dec 10, 2012 at 1:51

David G

97.6k41 gold badges173 silver badges258 bronze badges

Comments

Yogendra Singh · Accepted Answer · 2012-12-10 01:55:21Z

0

If you want to alert the match found then use a flag to mark where match was found or no. In the end, use the flag to alert the respective message as below:

 var find = ['iphone 3', 'iphone 4', 'iphone 5'];
 var search = 'iphone 5';
 var present = false;
 for(i=0; i<find.length; i++) {
     if(search == find[i]) {
       present = true;
       break;
     }
 }
 if(present) {
  alert('Yes');
 } else {
  alert('No');
 }

Please Note: There could be better ways but trying the help following your algorithm only.

answered Dec 10, 2012 at 1:55

Yogendra Singh

34.5k7 gold badges66 silver badges73 bronze badges

Collectives™ on Stack Overflow

Error when compare value in array using javascript?

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related