PHP: testing session

Question

Why is the construction brittle? I tried "!empty ( get_original_passhash() )" as a condition, but it ignites the error that you cannot use the return value.

if (  get_original_passhash () != '' ) 
{
    set_login_session ( get_original_passhash() );
}else
    print("Please, log in.");

uh? What are those functions they're not in standard php lib so unless we guess what they do or where do they come from we won't be able to help you. — p4bl0
– p4bl0, Commented Sep 4, 2009 at 15:49
Please put the relevant code in your question rather than on a third party site. — John Carter
– John Carter, Commented Sep 4, 2009 at 21:51

EvilChookie · Accepted Answer · 2009-09-04 16:03:15Z

2

I would be inclined to assign the variable before you test it, and probably also clean up your formatting a little too:

$original_hash = get_original_passhash();

if ($original_hash != ""){
    set_login_session(get_original_passhash());
} else {
    print("Please Log In");
}

You should also ensure that get_original_passhash() is returning the right type of variable - interger, string, boolean, etc.

Edit:

function get_original_passhash(){
    $dbconn = pg_connect("host=localhost port=5432 dbname=heoa user=heoa password=123");

    if(!empty($passhash_session)){
        return $passhash_session;
    } else {
        return $passhash_post;
    }
}

What is this code supposed to do? It connects to a database, and then tests a variable that just appears out of nowhere? Your code isn't working because, from the example's you've provided us, nothing is even being set. Is this the full source code for this function?

edited Sep 4, 2009 at 16:03

answered Sep 4, 2009 at 15:50

EvilChookie

5733 gold badges14 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

hhh Over a year ago

+1 good point, the function get_original_passh was unnecessary.

Lucas Oman · Accepted Answer · 2009-09-04 16:01:02Z

1

You may want to split up your logic:

if (is_logged_in()) {
  set_login_session(get_original_passhash());
} else {
  print("Please Log In");
}

Since, in the conditional, you don't want the pass hash. You want to know if they're logged in or not.

edited Sep 4, 2009 at 16:01

answered Sep 4, 2009 at 15:54

Lucas Oman

15.9k2 gold badges47 silver badges45 bronze badges

Collectives™ on Stack Overflow

PHP: testing session

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related