Using css in jquery

Question

I am using following code. The first if condition is working, but the second if is not. I don't know why? The same CSS should be applied in the second if also. Can anyone tell me why this is?

<script type="text/javascript">
    if (location.pathname.indexOf("girl-clothing") != -1) {
        $(".RetailPriceValue").css("cssText", "margin: -203px 0 0 0 !important;");
    }

    if (location.pathname.indexOf("http://www.xyz.com/girl-clothing/?sort=featured&page=2")!= -1) {
        $(".RetailPriceValue").css("cssText", "margin:-220px 0 0 0 !important;");
    }
</script>

What is that 'cssText' property name?

Bram Vanroy
– Bram Vanroy

2012-12-12 09:38:26 +00:00
Commented Dec 12, 2012 at 9:38 — Bram Vanroy
– Bram Vanroy, Commented Dec 12, 2012 at 9:38
escape sequence of the indexOf ?

Ken Cheung
– Ken Cheung

2012-12-12 09:43:00 +00:00
Commented Dec 12, 2012 at 9:43 — Ken Cheung
– Ken Cheung, Commented Dec 12, 2012 at 9:43

Rory McCrossan · Accepted Answer · 2012-12-12 09:40:58Z

1

I would imagine that the first style change is working by coincidence. What you're actually adding is this:

<div style="cssText: margin: -203px 0 0 0 !important;"></div>

The problems here are obvious. Try this instead:

if (location.pathname.indexOf("girl-clothing") != -1) {
    $(".RetailPriceValue").css("margin", "-203px 0 0 0 !important;");
}

if (location.pathname.indexOf("http://www.xyz.com/girl-clothing/?sort=featured&page=2")!= -1) {
    $(".RetailPriceValue").css("margin", "-220px 0 0 0 !important;");
}

answered Dec 12, 2012 at 9:40

Rory McCrossan

338k41 gold badges321 silver badges353 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Rash Over a year ago

No its not working second css is not applying there.it is taking first css only.why?

Rory McCrossan Over a year ago

Try removing the !important flags. Does the condition definitely hit? If you put an alert() in the second if statement does it appear?

Rory McCrossan Over a year ago

In that case the problem is with your second if statement not matching the url - nothing to do with the .css()

Rash Over a year ago

then how to use that url?i want to apply it in that page?

Rory McCrossan Over a year ago

You may want to double check the URL matches then. It's probably best to ask a different question about that though.

Mayank K. Swami · Accepted Answer · 2012-12-12 09:38:53Z

1

use something like

$(".RetailPriceValue").css( "margin","-220px 0 0 0 !important");

so try instead

if (location.pathname.indexOf("girl-clothing") != -1) {
    $(".RetailPriceValue").css("margin","-203px 0 0 0 !important");
}

if (location.pathname.indexOf("http://www.xyz.com/girl-clothing/?sort=featured&page=2")!= -1) {
    $(".RetailPriceValue").css( "margin","-220px 0 0 0 !important");
}

answered Dec 12, 2012 at 9:38

Mayank K. Swami

57.3k23 gold badges130 silver badges148 bronze badges

3 Comments

Rash Over a year ago

I have removed it,but still second css is not applying.atleast can you tell me how to remove "margin: -203px 0 0 0 !important" at this "xyz.com/girl-clothing/?sort=featured&page=2" url???

Rash Over a year ago

what do you mean by stray??I think becoz of girl clothing it is taking previous css.isnt it?

Mayank K. Swami Over a year ago

@user1326201 is my anser helping or solving your problem ...?

Scipion · Accepted Answer · 2012-12-12 11:24:12Z

1

if your location.href is http://www.xyz.com/girl-clothing/?sort=featured&page=2

the location.pathname will be "/girl-clothing/", so indexOf function never will find the string "http://"

https://developer.mozilla.org/en-US/docs/DOM/window.location

answered Dec 12, 2012 at 11:24

Scipion

1,3801 gold badge10 silver badges17 bronze badges

Collectives™ on Stack Overflow

Using css in jquery

3 Answers 3

5 Comments

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

5 Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related