Scala first program - error

Question

This is my first program on Scala. So, I hope I'll get the immunity of stupidity.

The code is a one line modification of a snippet from Programming in Scala.

All I am doing is

reading a text file
iterating the lines of the file
printing the max length of the lines in the file.

That works.

Now, when I try to print each line along with the length of the line with

println (eachLine + ":" + eachLine.length)

it throws an error.

I understand from this link in SO that I am supposed to add a parenthesis somewhere. But where and why?

import scala.io.Source

class Loops {

}

object Loops{

  def main (args:Array[String]){
    printAllLines("Hello123.txt")
  }


  def printAllLines(fileName:String){

    var maxWidth=0
    var lineIterator=Source.fromFile(fileName).getLines;
    lineIterator.foreach((eachLine:String) =>
        println (eachLine + ":" + eachLine.length)
        maxWidth=maxWidth.max(eachLine.length) //Compilation ERROR at this line

    )
    Console.out.println (maxWidth)
  }

//THIS WORKS !!

def printAllLinesFor(fileName:String){

    var maxWidth=0

    for (eachLine<-Source.fromFile(fileName).getLines.toList){

        println (eachLine + ":" +eachLine.length)
        maxWidth=maxWidth.max(eachLine.length)

    }

    println (maxWidth)
 }

}

ERROR : value maxWidth is not a member of Unit //possible cause: maybe a semicolon is missing before `value maxWidth'?

Brian Hsu · Accepted Answer · 2012-12-13 07:50:54Z

10

Change

lineIterator.foreach((eachLine:String) =>
    println (eachLine + ":" + eachLine.length)
    maxWidth=maxWidth.max(eachLine.length) //Compilation ERROR at this line

)

to

lineIterator.foreach{ (eachLine:String) =>
    println (eachLine + ":" + eachLine.length)
    maxWidth=maxWidth.max(eachLine.length) //Compilation ERROR at this line

}

should fix this problem.

Notice the difference between foreach {...} and foreach (...), if your foreach block has multiple lines, you should use {}.

answered Dec 13, 2012 at 7:50

Brian Hsu

8,8213 gold badges50 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Brian · Accepted Answer · 2012-12-13 07:51:01Z

7

The foreach needs braces for a multiline function.

    lineIterator.foreach((eachLine:String) => {
        println (eachLine + ":" + eachLine.length)
        maxWidth=maxWidth.max(eachLine.length) //Compilation ERROR at this line
    })

answered Dec 13, 2012 at 7:51

Brian

20.3k6 gold badges36 silver badges55 bronze badges

Comments

Frank Schmitt · Accepted Answer · 2012-12-13 07:57:49Z

1

When you add the println line, you extend the block; it had only one line before, but now it has two lines. Therefore, you have to put curly braces around it:

lineIterator.foreach((eachLine:String) => {
  println (eachLine + ":" + eachLine.length)
  maxWidth = maxWidth.max(eachLine.length) 
}

answered Dec 13, 2012 at 7:57

Frank Schmitt

30.5k13 gold badges79 silver badges111 bronze badges

Collectives™ on Stack Overflow

Scala first program - error

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related