JavaScript Validation error?

Question

I have been working on a JavaScript validator, but for some reason, evalid always returns as false even if it has passed validation... this is a bug as if evalid is false, the form doesn't submit.

function signup_validate()
    {
        document.getElementById("email_error").innerHTML = "";
        document.getElementById("password_error").innerHTML = "";
        evalid = false;
        pvalid = false;
        email = null;
        pass = null;
        confpass = null;
        email=document.forms["signup_form"]["email"].value.replace(/^\s+|\s+$/g, '');
        atpos=email.indexOf("@");
        dotpos=email.lastIndexOf(".");
        pass=document.forms["signup_form"]["pass"].value;
        confpass=document.forms["signup_form"]["confpass"].value;
            if (atpos<1 || dotpos<atpos+2 || dotpos+2>=email.length)
            {
                document.getElementById("email_error").innerHTML = "<span class='required'>Email must be valid.</span>";
            }
            else
            {
                $.post('/resources/forms/signup.php',{email: email}, function(data){
                    if(data.exists){
                        document.getElementById("email_error").innerHTML = "<span class='required'>This email is already in use.</span>";
                    }
                    else
                    {
                        evalid = true;
                    }
                }, 'JSON');
            }
            if (pass!=""&&pass!=null&&confpass!=""&&confpass!=null&&confpass==pass)
            {
                pvalid = true;
            }
            else
            {
                document.getElementById("password_error").innerHTML = "<span class='required'>Both passwords must match and cannot be left blank.</span>";
            }
            alert(evalid);
            if (evalid == true && pvalid == true)
            {
                document.getElementById("signup_form").submit();
            }
            else
            {
                return false;
            }
        }

What could I have missed?

Where are you returning evalid. What I see is your function gets to the end and returns nothing. — CrazyCasta
– CrazyCasta, Commented Dec 15, 2012 at 4:02

Josep · Accepted Answer · 2012-12-15 04:20:53Z

2

The only moment when you set "evalid" true is inside a function that runs asynchronously. In other words, by the time you set "evalid" true the main function has already reached the end.

You Could try to use $.ajax instead of $.post and use the parameter async:false

Try something like this:

$.ajax({
    type: 'POST',       
    url: '/resources/forms/signup.php',
    data: {email: email},
    success: function(response){
        //your function here
    },
    dataType:'JSON',
    async:false
});

edited Dec 15, 2012 at 4:20

answered Dec 15, 2012 at 4:03

Josep

13.1k2 gold badges44 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

12 Comments

user115422 Over a year ago

ok, then how would I rectify this? I see where you are going, as it makes sense now.

user115422 Over a year ago

im a bit new to javascript so im not sure what the solution would be.

elclanrs Over a year ago

@fermionoid: You have two options. 1. Do a synchronous request. 2. Use a callback.

user115422 Over a year ago

@elclanrs how would I make this synchronous? sorry, JS noob :)

user115422 Over a year ago

I mean without using $.ajax as now i need to rewrite my script... i dont know how i would do that...

|

Collectives™ on Stack Overflow

JavaScript Validation error?

1 Answer 1

12 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

12 Comments

Your Answer

Sign up or log in

Post as a guest

Related