PHP fetches URL without query

Question

I am trying to fetch from a service using jQuery and PHP (as a Proxy).

Here is my PHP that fetches the JSON.

<?php 

    if (!isset($_GET['url'])) die();
    $url =  urldecode($_GET['url']);
    $url = 'http://' . str_replace('http://', '', $url);
    echo file_get_contents($url);

 ?>

With the JS to manipulate the data (Sorry had to remove the key):

var api ='proxy.php?url=http://api.buycraft.net/v3?secret=MY-SECRET-KEY&action=payments';

$.getJSON(api, function(data){
     $.each(data, function(i, donor){
       console.log(donor);
     });
});

So going to proxy.php?url=http://api.buycraft.net/v3?secret=MY-SECRET-KEY&action=payments only returns the following:

{"code":100,"payload":[]}

But if I visit the JSON directly, I can see the data that I want

{
"code": 0,
"payload": [
{
"time": 1349661897,
"packages": [
"49381"
],
"ign": "notch",
"price": "15.99",
"currency": "USD"
}

For example.

And I know it's because php removes the ?action=payments query. Even if I use & instead of &. So is there a way to keep PHP from removing the query from the URL?

charlietfl · Accepted Answer · 2012-12-16 14:12:58Z

1

Keep the API key in your php and don't expose it to client side in your javascript for obvious security reasons. You might just as well store the whole URL (other than proxy.php) in your php config.

Also should implement use of CURL to retireve data. Allows for some error handling so you can send info back to client should API not be available

edited Dec 16, 2012 at 14:12

answered Dec 16, 2012 at 14:03

charlietfl

172k14 gold badges125 silver badges154 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

charlietfl Over a year ago

should be able to simply use it as is from there, no url_encoding needed

devs Over a year ago

Thanks for reminding me. Just wrapped it in a php function and called it a day.

Ray Paseur · Accepted Answer · 2012-12-16 14:00:34Z

0

Try removing this from the backend PHP script:

$url =  urldecode($_GET['url']);

PHP performs that automatically for you.

answered Dec 16, 2012 at 14:00

Ray Paseur

2,2042 gold badges14 silver badges17 bronze badges

Collectives™ on Stack Overflow

PHP fetches URL without query

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related