executing javascript functions within a string

Question

Is there a better way to inject a dynamic text into the html string other than the code specified below?

var code = 'siteCode1';

html code as a string:

existing: '<p>Log in with your'+ eval("siteVarObj('+code+').siteName") +'account</p>',


function siteVarObj(siteCode){
            if(siteCode === 'siteCode1'){
                this.siteName = 'google.com';
                this.siteContactUsURL = '';
            }else if(siteCode === 'siteCode2'){
                this.siteName = 'stackoverflow.com';
                this.siteContactUsURL = '';
            }
            return this;
        }

BLSully · Accepted Answer · 2012-12-20 19:59:42Z

5

This should work just fine:

var code = 'siteCode1';
var myHTMLString = '<p>Log in with your '+ siteVarObj(code).siteName + ' account</p>';

answered Dec 20, 2012 at 19:59

BLSully

5,9291 gold badge29 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Thomas · Accepted Answer · 2012-12-20 20:04:05Z

0

I would generally suggest to avoid execution of any input from within eval because eval opens up your code for injection attacks when used inproperly.

answered Dec 20, 2012 at 20:04

Thomas

1,3129 silver badges16 bronze badges

Collectives™ on Stack Overflow

executing javascript functions within a string

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related