103

Suppose I have a class with a string instance attribute. Should I initialize this attribute with "" value or None? Is either okay?

def __init__(self, mystr="")
   self.mystr = mystr

or

def __init__(self, mystr=None)
   self.mystr = mystr

Edit: What I thought is that if I use "" as an initial value, I "declare" a variable to be of string type. And then I won't be able to assign any other type to it later. Am I right?

Edit: I think it's important to note here, that my suggestion was WRONG. And there is no problem to assign another type to a variable. I liked a comment of S.Lott: "Since nothing in Python is "declared", you're not thinking about this the right way."

1
  • 10
    Since nothing in Python is "declared", you're not thinking about this the right way. Commented Sep 9, 2009 at 9:52

11 Answers 11

98

If not having a value has a meaning in your program (e.g. an optional value), you should use None. That's its purpose anyway.

If the value must be provided by the caller of __init__, I would recommend not to initialize it.

If "" makes sense as a default value, use it.

In Python the type is deduced from the usage. Hence, you can change the type by just assigning a value of another type.

>>> x = None
>>> print type(x)
<type 'NoneType'>
>>> x = "text"
>>> print type(x)
<type 'str'>
>>> x = 42
>>> print type(x)
<type 'int'>
Sign up to request clarification or add additional context in comments.

2 Comments

+1: What is the meaning of None or ""? The design choice depends entirely on which value is more meaningful.
In the example above, the "type" of x has not changed. Instead you have 3 different objects of different types: >>> x = None >>> id(x) 1461526688 >>> x = "text" >>> id(x) 2520221413080 >>> x = 42 >>> id(x) 1461692432 Instead, the label x has been moved around the three objects.
17

Another way to initialize an empty string is by using the built-in str() function with no arguments.

str(object='')

Return a string containing a nicely printable representation of an object.

...

If no argument is given, returns the empty string, ''.

In the original example, that would look like this:

def __init__(self, mystr=str())
   self.mystr = mystr

Personally, I believe that this better conveys your intentions.

Notice by the way that str() itself sets a default parameter value of ''.

3 Comments

For immutable types is the result the same as '', 0, False, (). For mutable types it is even so bad as [], {}, set() etc. because that initialization function for default is called only once and the result is used for _init_ repeatedly..
@hynekcer, you should not use mutable types as default value anyway. It's an anti-pattern.
@comte I knew it. The point of my comment was the same. A default =str() is not better than =''. A similar =list() would be even so dangerous as =[]. (Maybe I should have written "the result would be used repeatedly" not "is used" to make it clear.)
16

None is used to indicate "not set", whereas any other value is used to indicate a "default" value.

Hence, if your class copes with empty strings and you like it as a default value, use "". If your class needs to check if the variable was set at all, use None.

Notice that it doesn't matter if your variable is a string initially. You can change it to any other type/value at any other moment.

Comments

7

It depends. If you want to distinguish between no parameter passed in at all, and an empty string passed in, you could use None.

Comments

7

Either might be fine, but I don't think there is a definite answer.

  • If you want to indicate that the value has not been set, comparing with None is better than comparing with "", since "" might be a valid value,
  • If you just want a default value, "" is probably better, because its actually a string, and you can call string methods on it. If you went with None, these would lead to exceptions.
  • If you wish to indicate to future maintainers that a string is required here, "" can help with that.

Complete side note:

If you have a loop, say:

def myfunc (self, mystr = ""):
    for other in self.strs:
        mystr = self.otherfunc (mystr, other)

then a potential future optimizer would know that str is always a string. If you used None, then it might not be a string until the first iteration, which would require loop unrolling to get the same effects. While this isn't a hypothetical (it comes up a lot in my PHP compiler) you should certainly never write your code to take this into account. I just thought it might be interesting :)

1 Comment

Good comments, but you should avoid using str as a variable name, since it will shadow the built-in str() function.
3

Either is fine, though None is more common as a convention - None indicates that no value was passed for the optional parameter.

There will be times when "" is the correct default value to use - in my experience, those times occur less often.

Comments

2
empty_string = ""

if not empty_string:

    print "Empty string is not set"

=>Empty string is not set

if empty_string is not None:
    print "Empty string is not None"

=>Empty string is not None

Comments

1

Since both None and "" are false, you can do both. See 6.1. Truth Value Testing.

Edit

To answer the question in your edit: No, you can assign a different type.

>>> a = ""
>>> type(a)
<type 'str'>
>>> a = 1
>>> type(a)
<type 'int'>

2 Comments

Well, if he checks for truth, then he'll miss that "" might be a valid value. Better that he checks for Noneness instead.
Since we don't know what the OP is checking for, neither you nor me can judge what is better for him. BTW, did you consider my clearly marked edit, that answers the OPs edit, when you downvoted my answer?
1

For lists or dicts, the answer is more clear, according to http://python.net/~goodger/projects/pycon/2007/idiomatic/handout.html#default-parameter-values use None as default parameter.

But also for strings, a (empty) string object is instanciated at runtime for the keyword parameter.

The cleanest way is probably:

def myfunc(self, my_string=None):
    self.my_string = my_string or "" # or a if-else-branch, ...

1 Comment

Why? That' the job of the default parameter, so why do it twice? And why not be explicit about which value is the default? And, additionally, "" declares quite obviously that the function expects a string, which None doesn't tell you.
1

Either way is okay in python. I would personally prefer "". but again, either way is okay

>>>x = None
>>>print(x)
None
>>>type(x)
<class 'NoneType'>
>>>x = "hello there"
>>>print(x)
hello there
>>>type(x)
<class 'str'>
>>> 
>>>x = ""
>>>print(x)

>>>type(x)
<class 'str'>
>>>x = "hello there"
>>>type(x)
<class 'str'>
>>>print(x)
hello there

Comments

1

Python philosophy is to be readable.
That's why it's good practice to define your attributes in __init__() even if it's optional.
In the same spirit, you have to ask yourself what clearer for anyone who reads your code. In fact the type itself give much information about future use of your variable. So:

kind = None

Is syntaxically correct, but reader does not know much. Is it a string, a code as integer, a list, etc. ?

kind_str = None
kind = ""

Both say a little more, the first has the type in its name and the second in its declaration. I would go for the second, neater.

Comments

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.