Simple javascript prototype issue

Question

I am trying to attach an onclick function to every a tag.

I have

task.prototype.init=function(){  
        for (value in obj){
            var Link=document.createElement('a');
                Link.innerHTML='click';
                Link.id=value;   //I want to get the value
                Link.href='#'
                Link.onclick=this.changeName;
                document.body.appendChild(Link);
         }
}

task.prototype.changeName=function(){  

        //I want to get the clicked element id and I am not sure how to do it. 

    return false;
    }

Is there anyway to accomplish this?

What is this obj and where it is defined?

Teemu
– Teemu

2012-12-21 19:44:58 +00:00
Commented Dec 21, 2012 at 19:44 — Teemu
– Teemu, Commented Dec 21, 2012 at 19:44
what is obj? what is task?

jbabey
– jbabey

2012-12-21 19:45:25 +00:00
Commented Dec 21, 2012 at 19:45 — jbabey
– jbabey, Commented Dec 21, 2012 at 19:45

Wolfgang Stengel · Accepted Answer · 2012-12-21 19:49:16Z

1

Inside an event handler, this is the object that created the event, so this should work:

task.prototype.changeName=function() { alert(this.id); };

answered Dec 21, 2012 at 19:49

Wolfgang Stengel

2,8561 gold badge19 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

T. Junghans · Accepted Answer · 2012-12-21 19:51:37Z

0

I have created an example in a fiddle: http://jsfiddle.net/dWPCS/2/

In your event handler changeNamethe this references to the element. So this.idreturns the value you want.

answered Dec 21, 2012 at 19:51

T. Junghans

11.7k8 gold badges55 silver badges78 bronze badges

3 Comments

katspaugh Over a year ago

Confusing. Don't do this. Methods are expected to be called in the context of the corresponding instance.

T. Junghans Over a year ago

@katspaugh I'm providing a solution. It may not be the perfect one but in the real world, no one enters code into a beauty contest.

katspaugh Over a year ago

TJ., it isn't about beauty. It's about maintainability. The guy you'd provided the solution to was immediately confused and asked a follow-up question.

Collectives™ on Stack Overflow

Simple javascript prototype issue

2 Answers 2

Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related