C# Returning custom class Array

Question

I have a custom class defined:

class Car
{
    public string a;
    public string b;
    public string c;

    public static void GetCar()
    {
        var car = new Car[4];
        for(int i=0; i<4; ++i)
        {
            novica[i]= new Novica();
            novica[i].a="abc";
            novica[i].b="abc";
            novica[i].c="abc";
        }

    }
}

This fills the array with values, and now I would like to use this array with the values it gets (loading string from HTML) in a function that is not part of this class. Is it possible and if so, how?

Sorry about novica - it's supposed to be car there. Copy and paste:D — fanboy555
– fanboy555, Commented Dec 26, 2012 at 17:57

Eric Petroelje · Accepted Answer · 2012-12-26 18:01:55Z

5

In order to use it elsewhere, you would need to return the array from your function, like so:

public static Car[] GetCar()
    {
        var car = new Car[4];
        for(int i=0; i<4; ++i)
        {
            car[i]= new Novica();
            car[i].a="abc";
            car[i].b="abc";
            car[i].c="abc";
        }

        return car;
    }

edited Dec 26, 2012 at 18:01

answered Dec 26, 2012 at 17:54

Eric Petroelje

60.7k9 gold badges133 silver badges178 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Abe Miessler Over a year ago

This looks right. I think he wants to return novica though.

Justin Niessner · Accepted Answer · 2012-12-26 18:15:19Z

2

You can't. Your method doesn't actually return anything.

If you were to change the method signature to return the array the method creates:

public static Car[] GetCar()
{
    // Body

    return car;
}

The call would become as simple as:

var cars = Car.GetCar();

edited Dec 26, 2012 at 18:15

answered Dec 26, 2012 at 17:53

Justin Niessner

246k40 gold badges416 silver badges546 bronze badges

Comments

Olivier Jacot-Descombes · Accepted Answer · 2012-12-26 18:16:25Z

0

I suggest a slightly different construction. Provide an array containing all cars as static property

public class Car
{
    public static Car[] AllCars { get; private set; }

    public Car()
    {
        // Class and constructor somewhat simplyfied.
        AllCars = new Car[4];
        for (int i = 0; i < 4; ++i) {
            AllCars[i] = new Novica();
        }
    }
}

Now you can work with cars like this

foreach (Car car in Car.AllCars) {
    // do something with car
}

Or access a specific car with

string a = Car.AllCars[i].a;

answered Dec 26, 2012 at 18:16

Olivier Jacot-Descombes

114k14 gold badges149 silver badges202 bronze badges

Collectives™ on Stack Overflow

C# Returning custom class Array

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related