Correct syntax for using php to set <div> attribute

Question

I need to set a div's background colour using PHP. Here's what I'm doing at the moment:

<div class="box" style="background-color:"<?php echo $permacolour; ?>"">

However, this isn't working. What am I doing wrong?

Thanks

Your Common Sense · Accepted Answer · 2013-01-02 21:12:36Z

6

<div class="box" style="background-color:<?=$permacolour?>">

quotes do not belong to PHP syntax. PHP tags are <?, <?php and ?> only

answered Jan 2, 2013 at 21:12

Your Common Sense

158k42 gold badges226 silver badges373 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

ceejayoz Over a year ago

Good answer, but I'd note that <?php ?> is a perfectly acceptable syntax for this, OP doesn't have to use <?= ?> - it's the quotes, not the PHP tags, that are the problem.

idrumgood Over a year ago

Also, the <?= in this example is a short hand way of writing <?php echo

ficuscr Over a year ago

And requires short tags be enabled in PHP's ini file! :)

ficuscr Over a year ago

@Ascherer Nice. Good to know. Fingers crossed I'll start seeing less Smarty use as a result.

Jamund Ferguson · Accepted Answer · 2013-01-02 21:14:08Z

4

style="background-color:"<?php echo $permacolour; ?>""

You have two sets of quotes here. Try this:

style="background-color:<?php echo $permacolour; ?>"

answered Jan 2, 2013 at 21:14

Jamund Ferguson

17k3 gold badges47 silver badges51 bronze badges

Comments

Cyril N. · Accepted Answer · 2013-01-02 21:15:37Z

4

To be near your original post, here's the correct way :

<div class="box" style="background-color: <?php echo $permacolour; ?>">

The problem is that you were writing the background color surrounded by double quotes. The result would have been like

<div class="box" style="background-color:"red"">

instead of

<div class="box" style="background-color: red">

So just remove the double quotes between the value you are good to go.

Of course, this suppose you defined $permacolour or you made sure the value of $permacolour is sanitized and filtered if inputed by a user.

The answer of @your-common-sense is based on the shorthand syntax that is not always activated on hosted servers.

answered Jan 2, 2013 at 21:15

Cyril N.

40.1k40 gold badges165 silver badges269 bronze badges

1 Comment

Ascherer Over a year ago

Worth noting, Moving forward in php, after 5.4, <?= will always be available, regardless of the short_tag setting

Adeel Mughal · Accepted Answer · 2013-01-02 21:46:32Z

0

<div class="box" style="background-color:<?php echo $permacolour; ?>;">

answered Jan 2, 2013 at 21:46

Adeel Mughal

7364 silver badges13 bronze badges

Comments

Mahmoud Ilyan · Accepted Answer · 2013-01-06 12:36:22Z

0

remove the double quotes

style="<?php echo $permacolour ; ?>"

or without quotes at all would be easier for some versions in html

style=<?php echo $permacolor ;?>

answered Jan 6, 2013 at 12:36

Mahmoud Ilyan

412 bronze badges

Collectives™ on Stack Overflow

Correct syntax for using php to set <div> attribute

5 Answers 5

4 Comments

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

4 Comments

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related