Replace numeric value with another

Question

I have a span in my HTML as follows, which I am assigning the text from code behind:

<span id="NewL1" visible="false"
    runat="server"><span runat="server" id="NewL"></span></span>

The text would be something like : "you have 3 notifications."

I want to change the numeric value in jQuery. I have tried this but nothing happens:

var notification = $("#NewL");
var numb = notification.text().match(/\d/g);
var finalTotalCount = parseInt(numb) - 1;
notification.text(notification.text().replace(numb, finalTotalCount ));

What I am doing wrong?

I wouldn't go this way. Instead of replacing, generate the whole string from scratch, then update the DOM: this way you can be more flexible [e.g. use singular when there is one notification only], and you don't mess with regexes for such a task. — moonwave99
– moonwave99, Commented Jan 3, 2013 at 12:40
When is your JS code running? Onload? Are you sure that by then the span will have content? — Deleteman
– Deleteman, Commented Jan 3, 2013 at 12:40
@moonwave99 i am doing this as for future changes one place needs to be changed :) — Zaki
– Zaki, Commented Jan 3, 2013 at 12:43

Leniel Maccaferri · Accepted Answer · 2013-01-03 12:53:03Z

1

So you have this HTML code:

<span id="NewL1" visible="false" runat="server">
    <span runat="server" id="NewL">you have 3 notifications</span>
</span>

Then, your current JavaScript code just works provided that your dynamic text you have 3 notifications is being inserted in the right place, that is, within the inner span.

Here's the jsFiddle: http://jsfiddle.net/leniel/ykg62/2/

edited Jan 3, 2013 at 12:53

answered Jan 3, 2013 at 12:38

Leniel Maccaferri

103k48 gold badges381 silver badges495 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Cerbrus · Accepted Answer · 2013-01-03 12:47:48Z

1

Replace:

var finalTotalCount = parseInt(numb) - 1;

With:

var finalTotalCount = parseInt(numb[0]) - 1;

.match(/\d/g) returns an array of strings that match the regex. You'll want to get the first result of that array, assuming you only have 1 number in your text.

Edit

Apparently, parseInt uses the first element in the array, if a array is provided. So, technically, my suggestion isn't necessary.

edited Jan 3, 2013 at 12:47

answered Jan 3, 2013 at 12:39

Cerbrus

73.3k19 gold badges138 silver badges151 bronze badges

5 Comments

Zaki Over a year ago

Hi, I only have one number in the string. I can see the finalTotalCount decreasing but dont see it being replaced.

Cerbrus Over a year ago

@Deleteman: Hm, I see. Apparently, parseInt uses the first element in the array, if a array is provided. Still, best practices, right? Sam1: your code appears to work. Did you copy all your relevant code to the question?

Zaki Over a year ago

@Cerbrus didnt include the span inside another span see my edit of html please

Cerbrus Over a year ago

@Sam1: that shouldn't matter.

Zaki Over a year ago

@Deleteman +1 for suggestion...I think the first span is not visible or the fact that am assigning from code behind may be issue(although the text is there when the above jquery code runs)

palaѕн · Accepted Answer · 2013-01-03 13:14:07Z

1

Modify you code like this and try again

var notification = $("#NewL");
var numb = notification.text().match(/\d/g)[0];
var finalTotalCount = parseInt(numb) - 1;
notification.text(notification.text().replace(numb, finalTotalCount ));

Also, in your code:

<span id="NewL1" visible="false" runat="server">
    <span runat="server" id="NewL"></span>
</span>

You have span inside a hidden span(visible="false"). So won't be able to see any changes done. You can simply put your code like this and try again:

<span runat="server" id="NewL"></span>

answered Jan 3, 2013 at 13:14

palaѕн

74.2k17 gold badges123 silver badges140 bronze badges

Collectives™ on Stack Overflow

Replace numeric value with another

3 Answers 3

Comments

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related