Comparing in_array values

Question

I have a array of val which has dynamic strings with underscores. Plus I have a variable $key which contains an integer. I need to match $key with each $val (values before underscore).

I did the following way:

<?php
    $key = 2; //always a dynamic number
$val = array('3_33', '2_55'); //always a dynamic string with underscore
if(in_array($key, $val)) {
    echo 'Yes'; 
} 
else
{
    echo 'No';  
}
?>

Though this code works fine, I want to know if its a correct way or suggest some better alternative.

Your code would output no - is it intended? If so, what actually do you expect simpler than a single function call? — zerkms
– zerkms, Commented Jan 7, 2013 at 7:40
But what's wrong with using this existing code? This is clean and recommended by PHP Manual itself, so why look for complicated versions. Theoretically there are "better" ways of doing everything, but that is subjective — Hanky Panky
– Hanky Panky, Commented Jan 7, 2013 at 7:58
since you need to match only the part before the underscore, you should use a regex match or a string match. the above code shouldn't work although you say that it works. hmmm... see answer below — xtrahelp.com
– xtrahelp.com, Commented Jan 7, 2013 at 8:15

xtrahelp.com · Accepted Answer · 2013-01-07 08:19:18Z

1

use this function for regex match from php.net

function in_array_match($regex, $array) {
    if (!is_array($array))
        trigger_error('Argument 2 must be array');
    foreach ($array as $v) {
        $match = preg_match($regex, $v);
        if ($match === 1) {
            return true;
        }
    }
   return false;
}

and then change your code to use this function like this:

$key = 2; //always a dynamic number
$val = array('3_33', '2_55'); //always a dynamic string with underscore
if(in_array_match($key."_*", $val)) {
    echo 'Yes'; 
} 
else
{
    echo 'No';  
}

answered Jan 7, 2013 at 8:19

xtrahelp.com

9548 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

wakooka · Accepted Answer · 2013-01-07 09:03:16Z

1

This should work :

foreach( $val as $v ) 
{
    if( strpos( $v , $key .'_' ) === true ) 
    {
        echo 'yes';
    }
    else {
        echo 'no';
    }
}

edited Jan 7, 2013 at 9:03

answered Jan 7, 2013 at 7:44

wakooka

1,42811 silver badges15 bronze badges

1 Comment

xtrahelp.com Over a year ago

although i +1d this, you should note that since strpos will return 0 if the match is found, you should do the comparison using ===. so it should be changed to if( strpos( $v .'_' , $key ) === true)

user1000456 · Accepted Answer · 2013-01-07 07:41:26Z

0

you can use this

    function arraySearch($find_me,$array){
$array2 =array();
foreach ($array as $value) {
    $val = explode('_',$value);
    $array2[] =$val[0]; 
}
$Key = array_search($find_me, $array2);
$Zero = in_array($find_me, $array2);
if($Key == NULL && !$Zero){
    return false;
}
return $Key;
}

answered Jan 7, 2013 at 7:41

user1000456

Comments

score 0 · Accepted Answer · 2013-01-07 07:58:27Z

0

$key = 2; //always a dynamic number
$val = array('3_33', '2_55'); //always a dynamic string with underscore
$inarray = false;
foreach($val as $v){
    $arr = explode("_", $val);
    $inarray = $inarray || $arr[0] == $key
}
echo $inarray?"Yes":"No";

edited Jan 7, 2013 at 7:58

answered Jan 7, 2013 at 7:39

user1726343

9 Comments

zerkms Over a year ago

$val is an array, not a string

user1726343 Over a year ago

@zerkms Right, missed that. Thanks.

zerkms Over a year ago

1. It's php5.4 only 2. It's a huge overcomplication. strpos($val, $key) === 0 - would do the job better 3. you probably want to break; after you find entry.

wakooka Over a year ago

Seeing your answer, I'm confused with the answer that I gave. I thought the OP wanted to check the value before the underscore, did I misunderstand the question ?

user1726343 Over a year ago

@zerkms Point 2 is wrong, by the way. strpos is fooled by numbers that begin with the same digits but aren't exactly the same. Searching for 2 in "25_55" for example.

|

KingCrunch · Accepted Answer · 2013-01-07 08:13:37Z

0

The given format is quite unpractically.

$array2 = array_reduce ($array, function (array $result, $item) {
     list($key, $value) = explode('_', $item);
     $result[$key] = $value;
     return $result;
}, array());

Now you can the existence of your key just with isset($array2[$myKey]);. I assume you will find this format later in your execution useful too.

answered Jan 7, 2013 at 8:13

KingCrunch

133k22 gold badges158 silver badges174 bronze badges

Collectives™ on Stack Overflow

Comparing in_array values

5 Answers 5

Comments

1 Comment

Comments

9 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

1 Comment

Comments

9 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related