String make-up from an array using "foreach" or "for" Loop construct

Question

i need to use a for loop i think so I can access each property in each row in the array to make up my string.

  public static string GetHintText(this IEnumerable<UserTrainingPointsDataModel> HintTextString)
  {

    foreach (var part in HintTextString)
    {
      HintText = HintText + "  " + part.Name + "  " + part.IncentiveTrainingModuleOptionName + " = " + part.Points;
    }

    return HintText;
  }

  public class UserTrainingPointsDataModel
  {
    public virtual int InteractionType { get; set; }
    public virtual int Points { get; set; }
    public virtual string Name { get; set; }
    public virtual string IncentiveTrainingModuleOptionName { get; set; }
  }

each row constains values:

  China Incentive Program  Points For Completing = 50  
  India - Q2 Incentive   Points Per Correct Answer = 50  
  China - Q2 Incentive  Points For Completing = 50  
  India Incentive Program  Points Per Correct Answer = 100  
  India - Q2 Incentive   Points Per Correct Answer = 100

HintTextString contains 5 rows each with the properties above and i need to make up a string that looks like this:

  "Incentive Program: " + part.Name[0] + "  " + part.IncentiveTrainingModuleOptionName[0] + " + " + part.Points[0] + 
  "Incentive Program: " + part.Name[1] + "  " + part.IncentiveTrainingModuleOptionName[1] + " + " + part.Points[1]

etc. So i need a for loop rather? and how would I get the length of HintTextString? intellisense does not give me that property

The view:

 <% if (module.HasAssessment)
 { %>
    <div class="<%: moduleStateClass %>">&nbsp;</div>
    <div class="<%: moduleScoreClass %>"><%: module.ModuleScore %></div>
    <% var HintText =  TrainingModuleProgressStateDataModelExtentions.GetHintText(module.UserTrainingPoints); %>

    <script type="text/javascript">
       <%: Html.GetQTip("training-module-id-" + module.TrainingModuleId , "Incentive program: " + HintText , "training-module-id-" + module.TrainingModuleId , Zinc.Web.Extensions.QTipPosition.Bottom, true, "Module Points") %>
    </script> 
 <% }  %> 
 <% else
    {  %>
 <% var HintText =  TrainingModuleProgressStateDataModelExtentions.GetHintText(module.UserTrainingPoints); %>
 <script type="text/javascript">
    <%: Html.GetQTip("training-module-id-" + module.TrainingModuleId , "Incentive program: "  + HintText ,"training-module-id-" + module.TrainingModuleId , Zinc.Web.Extensions.QTipPosition.Bottom, true, "Module Points") %>   
 </script>
 <% } %>

"Action" :

  <div class="module-column-content">
    <% Html.RenderPartial("~/Areas/Training/Views/Home/Details.ascx", Model); %>
  </div>

Thanks

so you want to return the whole list as one sting

sa_ddam213
– sa_ddam213

2013-01-09 07:19:46 +00:00
Commented Jan 9, 2013 at 7:19 — sa_ddam213
– sa_ddam213, Commented Jan 9, 2013 at 7:19
post the action that generates the result

Jared
– Jared

2013-01-09 07:24:38 +00:00
Commented Jan 9, 2013 at 7:24 — Jared
– Jared, Commented Jan 9, 2013 at 7:24
Also post the view if possible

Jared
– Jared

2013-01-09 07:25:10 +00:00
Commented Jan 9, 2013 at 7:25 — Jared
– Jared, Commented Jan 9, 2013 at 7:25
i think you need nested for Loops

Prasad
– Prasad

2013-01-09 07:25:16 +00:00
Commented Jan 9, 2013 at 7:25 — Prasad
– Prasad, Commented Jan 9, 2013 at 7:25

sa_ddam213 · Accepted Answer · 2013-01-09 07:42:03Z

1

If you just want to return the whole list as one sting in the format you described this should work

public static string GetHintText(this IEnumerable<UserTrainingPointsDataModel> HintTextString)
{
    string returnValue = string.Empty;
    foreach (var dataModel in HintTextString)
    {
        returnValue += string.Format("Incentive Program: {0}  {1} + {2}  ", dataModel.Name, dataModel.IncentiveTrainingModuleOptionName, dataModel.Points);
    }
    return returnValue;
}

As Jared mentioned, if your collection is large you probably want to use StringBuilder as is much better on perfromance.

public static string GetHintText(this IEnumerable<UserTrainingPointsDataModel> HintTextString)
{
    var returnValue = new StringBuilder();
    foreach (var dataModel in HintTextString)
    {
        returnValue.AppendFormat("Incentive Program: {0}  {1} + {2}  ", dataModel.Name, dataModel.IncentiveTrainingModuleOptionName, dataModel.Points);
    }
    return returnValue.ToString();
}

edited Jan 9, 2013 at 7:42

answered Jan 9, 2013 at 7:29

sa_ddam213

43.7k7 gold badges105 silver badges112 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jared Over a year ago

When doing rapid string manipulation StringBuilder should be used... If there are 5000 items in the array/list this could be very "costly"

SWeko · Accepted Answer · 2013-01-09 07:44:59Z

Use a StringBuilder to construct the text, while iterating on the collection. It's optimized to work with string manipulation functions. If you use simple text adding (+=) in looping the performance can get abysmal.

public static string GetHintText(this IEnumerable<UserTrainingPointsDataModel> HintTextString)
{
  //format for each item 
  //{Name} {ModuleName} = {Points} <NewLine>
  string lineFormat = "Incentive Program: {0} {1} = {2}\r\n";
  StringBuilder sb = new StringBuilder();
  foreach (var part in HintTextString)
  {
     sb.AppendFormat(lineFormat, part.Name, part.IncentiveTrainingModuleOptionName, part.Points);
  }

  return sb.ToString();
}

Also, if you need the length of the HintTextString collection, you can use the IEnumerable.Count() extension method.

Collectives™ on Stack Overflow

String make-up from an array using "foreach" or "for" Loop construct

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related