Trying to create an Array of Objects

Question

I have an object I am trying to put in an array list:

class PlayerScores {

String playerName;
int played=0;
int win=0;
int draw=0;
int loss=0;
int points=0;


void playerNameSet(String name){
    playerName=name;
}
void played(){
    played=played+1;
}
void win(){
    win=win+1;
    points();
}
void draw(){
    draw=draw+1;
    points();
}
void loss(){
    loss=loss+1;
}

void points(){
    points = (win*3)+draw;
}

}

and basically, when the user has chose how many players there are I want to initialize an Array of these objects but I am getting errors. Here is the code for initializing the array and then assigning names to the players as well.

the array has been defined at the begining of my code and is public so I can use it in different activities: "PlayerScores[] playersObjects;"

public PlayerScores[] makePlayerObjects() {
        playersObjects = new PlayerScores[players];
        for(int i = 0; i < players + 1; i++)
        {
            playersObjects[i].playerNameSet(name variable);
        }

    return playersObjects;
}

the error seems occur on the line where the name is being set but it is not to do with the name variable.

Any help would be massively appreciated, Thanks, Oli

A--C · Accepted Answer · 2013-01-09 17:02:06Z

9

You haven't actually set the objects in the Array. You first need to construct a PlayerScores object then you can access it.

public PlayerScores[] makePlayerObjects() {
        playersObjects = new PlayerScores[players];
        for(int i = 0; i < playersObjects.length; i++)
        {
            playersObjects[i] = new PlayerScores(); //make the object so we can access it
            playersObjects[i].playerNameSet(name variable);
        }

    return playersObjects;
}

edited Jan 9, 2013 at 17:02

answered Jan 9, 2013 at 16:55

A--C

36.4k10 gold badges109 silver badges92 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

petey · Accepted Answer · 2013-01-09 16:53:52Z

2

you could also use a list.

 List<PlayerScores > myList = new ArrayList<PlayerScores>();
 for(int i = 0; i < players.size(); i++){
        myList.add(new PlayerScores().playerNameSet(thename));
 }

also note the .size() usage assuming players is a different array. if it is a int then forget the .size() part

answered Jan 9, 2013 at 16:53

petey

17.2k6 gold badges70 silver badges103 bronze badges

Comments

Blackbelt · Accepted Answer · 2013-01-09 16:50:09Z

1

for(int i = 0; i < players + 1; i++)

it will cause ArrayIndexOutOfBoundException, because array's index go from 0 to size -1

answered Jan 9, 2013 at 16:50

Blackbelt

158k31 gold badges308 silver badges310 bronze badges

3 Comments

Oli Black Over a year ago

I'm sorry but I am not sure exactly what you mean, what part of that for loop do I need to change?

ceptno Over a year ago

take out the +1, it should be for(int i = 0; i < playersObject.length)

Blackbelt Over a year ago

@OliBlack the exit condition of the for loop. Since the array indexes go from 0 to array size - 1, the exit condition should be i < players. That is a very basically programming qustion

Collectives™ on Stack Overflow

Trying to create an Array of Objects

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related