Regex.Replace much slower than conditional statement using String.Contains

Question

I have a list of 400 strings that all end in "_GONOGO" or "_ALLOC". When the application starts up, I need to strip off the "_GONOGO" or "_ALLOC" from every one of these strings.

I tried this: 'string blah = Regex.Replace(string, "(_GONOGO|_ALLOC)", ""));'

but it is MUCH slower than a simple conditional statement like this:

if (string.Contains("_GONOGO"))
          // use Substring
else if (string.Contains("_ALLOC"))
          // use Substring w/different index

I'm new to regular expressions, so I'm hoping that someone has a better solution or I am doing something horribly wrong. It's not a big deal, but it would be nice to turn this 4 line conditional into one simple regex line.

Does your regex perform any better if you put a $ anchor on the end of the pattern? — Mark Rushakoff
– Mark Rushakoff, Commented Sep 15, 2009 at 0:36
You should use EndsWith instead of Contains. Along with being more correct, it's faster. :) — Sam Harwell
– Sam Harwell, Commented Sep 15, 2009 at 0:56

Adam Robinson · Accepted Answer · 2009-09-15 00:36:30Z

8

While it isn't RegEx, you could do

string blah = string.Replace("_GONOGO", "").Replace("_ALLOC", "");

RegEx is great for complex expressions, but the overhead can sometimes be overkill for very simple operations like this.

answered Sep 15, 2009 at 0:36

Adam Robinson

186k36 gold badges294 silver badges351 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

alexD Over a year ago

Thank you, this is just fine - regex wasn't a requirement I just wanted it down to one line.

David Andres · Accepted Answer · 2009-09-15 00:38:42Z

4

Regex replacements may work faster if you compile the regex first. As in:

Regex exp = new Regex(
    @"(_GONOGO|_ALLOC)",
    RegexOptions.Compiled);

exp.Replace(string, String.Empty);

answered Sep 15, 2009 at 0:38

David Andres

31.9k7 gold badges48 silver badges36 bronze badges

2 Comments

TrueWill Over a year ago

Note also (from MSDN) "The Regex class is immutable (read-only) and is inherently thread safe." You can create it once and assign it to a static readonly field. See acorns.com.au/blog/?p=136

TrueWill Over a year ago

And from the Atwood Archives: codinghorror.com/blog/archives/000228.html

Michael Petrotta · Accepted Answer · 2009-09-15 00:43:34Z

3

This is expected; in general, manipulating a string by hand will be faster than using a regular expression. Using a regex involves compiling an expression down to a regex tree, and that takes time.

If you're using this regex in multiple places, you can use the RegexOptions.Compiled flag to reduce the per-match overhead, as David describes in his answer. Other regex experts might have tips for improving the expression. You might consider sticking with the String.Replace, though; it's fast and readable.

answered Sep 15, 2009 at 0:43

Michael Petrotta

61.1k27 gold badges153 silver badges181 bronze badges

Comments

Av Pinzur · Accepted Answer · 2009-09-15 00:52:35Z

1

If they all end in one of those patterns, it would likely be faster to drop replace altogether and use:

string result = source.Substring(0, source.LastIndexOf('_'));

answered Sep 15, 2009 at 0:52

Av Pinzur

2,22815 silver badges15 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 12:11:21Z

1

When you have that much information about your problem domain, you can make things pretty simple:

const int AllocLength = 6;
const int GonogoLength = 7;
string s = ...;
if (s[s.Length - 1] == 'C')
    s = s.Substring(0, s.Length - AllocLength);
else
    s = s.Substring(0, s.Length - GonogoLength);

This is theoretically faster than Abraham's solution, but not as flexible. If the strings have any chance of changing then this one would suffer from maintainability problems that his does not.

edited May 23, 2017 at 12:11

CommunityBot

11 silver badge

answered Sep 15, 2009 at 0:54

Sam Harwell

100k22 gold badges216 silver badges283 bronze badges

Collectives™ on Stack Overflow

Regex.Replace much slower than conditional statement using String.Contains

5 Answers 5

1 Comment

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related