Java mysql syntax error

Question

I get syntax error to mysql insert statement. May I know how to correct this error ?

user=txtuser.getText();
      char[] pass=jPasswordField1.getPassword();
             String passString=new String(pass);
            try{                
                Connection con = createConnection();               
                Statement st = con.createStatement();


**String sql = "INSERT INTO login(username,Password)"+"VALUES"+"('"user"','"passString"')";**
 st.executeUpdate(sql);
            }
            catch(Exception e){
                JOptionPane.showMessageDialog(null,"Exception: "+ e.toString());
            }

What does this have to do with jQuery? Retagging now.

Rory McCrossan
– Rory McCrossan

2013-01-10 12:01:27 +00:00
Commented Jan 10, 2013 at 12:01 — Rory McCrossan
– Rory McCrossan, Commented Jan 10, 2013 at 12:01

Reimeus · Accepted Answer · 2013-01-10 13:06:08Z

7

You're missing a few + operators:

String sql = "INSERT INTO login(username,Password) VALUES ('" + user + "','" + passString + "')";

Consider using PreparedStatement placeholders to set these parameters. This will protect you from SQL injection attacks also. Here is an example

edited Jan 10, 2013 at 13:06

answered Jan 10, 2013 at 12:00

Reimeus

160k16 gold badges225 silver badges282 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

user1966589 Over a year ago

please can u tell how to use preparestatement

Bhavik Shah Over a year ago

@user1966589 : roseindia.net/jdbc/jdbc-mysql/TwicePreparedStatement.shtml

user1966589 Over a year ago

@limelights now i get a run time error . java.lang.UnsupportedOperationException:Notyet implemented

Henrik Andersson Over a year ago

From where? Make a new question and post your code and stacktrace or update this question with the stacktrace, please.

Collectives™ on Stack Overflow

Java mysql syntax error

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related