using if function in textbox

Question

I have the following code behind a userform

Private Sub add_button()
    On Error Resume Next
     If TextBox1 > TextBox9 Then
         TextBox12 = "YES"
     Else
         TextBox12 = "No"
         If TextBox8 > TextBox3 And TextBox8 < TextBox4 Then
            TextBox11 = "YES"
         Else
            TextBox11 = "no"
            If TextBox12 = "NO" Then
                TextBox10 = "NO"
            ElseIf TextBox11 = "NO" Then
                TextBox10 = "NO"
            Else
                TextBox10 = "YES"
            End If
         End If
     End If
End Sub

The above code does not work: please advice on possible errors.

Hi, I think the problem is CASE SENSITIVE. if you want insentive comparsion, put option compare text on top of your module, or use ucase() to wrap your string. — Larry
– Larry, Commented Jan 24, 2013 at 3:33
On Error Resume Next Can you please remove this? and then tell us what doesn't work and what error are you gettng? — Siddharth Rout
– Siddharth Rout, Commented Jan 24, 2013 at 5:35

bonCodigo · Accepted Answer · 2013-01-24 06:40:16Z

1

Few things,

Remove error handling you will then know if there's an issue in execution as Siddharth's comment
Balance both left right comparison for text formats/ cases as Larry's comment
Use proper properties to get set values. In you case it is Textbox.Text
Run through the code in debug mode by pressing F8 and adding break points
Do Debug.Print or a Msgbox at each if-else to ensure the logic flow
Respond to comments as the community is trying their best to help you solve your issue.

Here is change you could do to your code. At this point of the logic you have already set both 12 and 11 to NO in that case it is unnecessary to do this check:

 If TextBox12 = "NO" Then 
     TextBox10 = "NO" 
 ElseIf TextBox11 = "NO" Then 
     TextBox10 = "NO"

You may simply set Textbox10.Text = "NO"

edited Jan 24, 2013 at 6:40

answered Jan 24, 2013 at 6:26

bonCodigo

14.4k1 gold badge52 silver badges93 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

whytheq · Accepted Answer · 2013-01-24 08:44:47Z

0

Please can you check that the actual conditions of the script are working as I'm a little unsure how well these conditions will work against text. Just copy out all the existing code and copy the following in as a test:

Private Sub add_button()
    If TextBox1 > TextBox9 Then
        MsgBox "TextBox1 > TextBox9 "
    Else
        MsgBox "TextBox1 < TextBox9 "
        If TextBox8 > TextBox3 And TextBox8 < TextBox4 Then
            MsgBox "TextBox8 > TextBox3 And TextBox8 < TextBox4 "
        End
    End If
End Sub

answered Jan 24, 2013 at 8:44

whytheq

35.7k69 gold badges179 silver badges283 bronze badges

Collectives™ on Stack Overflow

using if function in textbox

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related