Write a MVC custom validation for specific values

Question

I'm writing a MVC custom validation. It will be valid for list of specific values. Example:

[Values(30, 60, 120)]
public int SelectTop { get; set; }

But It doesn't work with my validation. This is codes:

public class ValuesAttribute : ValidationAttribute
{
    public object[] Values { get; private set; }

    public Type Type { get; private set; }

    public ValuesAttribute(params int[] values)
        : this(typeof(int), values)
    {
    }

    public ValuesAttribute(params double[] values)
        : this(typeof(double), values)
    {
    }

    public ValuesAttribute(Type type, params object[] values)
    {
        this.Type = type;
        this.Values = values;
    }

    public override bool IsValid(object value)
    {
        foreach (var v in this.Values)
        {
            if (object.Equals(v, value))
            {
                return true;
            }
        }

        return false;
    }
}

Please help me to find the problem. Thanks.

You're boxing value types then comparing them..

Simon Whitehead
– Simon Whitehead

2013-01-24 05:33:49 +00:00
Commented Jan 24, 2013 at 5:33 — Simon Whitehead
– Simon Whitehead, Commented Jan 24, 2013 at 5:33

heads5150 · Accepted Answer · 2013-01-24 05:31:51Z

1

This line

public object[] Values { get; private set; }

stores the array of values in it so Values[0] = int[3]

Change your code to:

   public override bool IsValid(object value) {
            int[] valueSet = this.Values[0] as int[];

            if (valueSet == null) {
                throw new Exception("Values must be provided");
            }

            foreach (var v in valueSet) {
                if (object.Equals(v, value)) {
                    return true;
                }
            }

            return false;
        }

answered Jan 24, 2013 at 5:31

heads5150

7,5333 gold badges28 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Leo Vo Over a year ago

stores the array of values in it so Values[0] = int[3] -> happen when they are different from type.

Collectives™ on Stack Overflow

Write a MVC custom validation for specific values

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related