How to get data form SQLite database and display it in ListView

Question

I have edited my previous post here.(How to use Android SQLite Database)

In this post I have changed the code for 'Show' button. Now I am trying to access the database. I have added a ListView and trying to display the content of database in it. But again getting the same error. ("Unfortunately learn has stopped.") on tapping the Show button.

Here is the complete code -

    package com.example.learn;

    import android.os.Bundle;
    import android.app.Activity;
    import android.database.Cursor;
    import android.database.sqlite.SQLiteDatabase;
    import android.view.Menu;
    import android.view.View;
    import android.view.View.OnClickListener;
    import android.widget.ArrayAdapter;
    import android.widget.Button;
    import android.widget.EditText;
    import android.widget.ListView;

    public class MainActivity extends Activity {

        Button b1, b2, b3;
        EditText t1;
        ListView lv1;
        SQLiteDatabase db;
        Cursor c;

        @Override
        protected void onCreate(Bundle savedInstanceState) {
            super.onCreate(savedInstanceState);
            setContentView(R.layout.activity_main);

            b1 = (Button) findViewById(R.id.button1);
            b2 = (Button) findViewById(R.id.button2);
            b3 = (Button) findViewById(R.id.button3);
            t1 = (EditText) findViewById(R.id.editText1);
            lv1 = (ListView) findViewById(R.id.listView1);

            db = openOrCreateDatabase("MyDB", MODE_PRIVATE, null);
            db.execSQL("CREATE TABLE IF NOT EXISTS Names(Name VARCHAR)");

            b1.setOnClickListener(new OnClickListener() {

                @Override
                public void onClick(View arg0) {
                    // TODO Auto-generated method stub

                    if (t1.getText().toString().equals("")) {
                        t1.setText("Enter Name");
                    }

                    else {
                        String input = t1.getText().toString();
                        db.execSQL("INSERT INTO Names VALUES(" + "'" + input + "'"
                                + ")");
                    }

                }
            });

            b2.setOnClickListener(new OnClickListener() {

                @Override
                public void onClick(View arg0) {
                    // TODO Auto-generated method stub
                    c = db.rawQuery("SELECT * FROM Names", null);
                    int count = c.getCount();

                    String[] values = new String[count + 1];
                    int i = 0;
                    do {
                        values[i] = c.getString(c.getColumnIndex("Name"));
                        i++;
                    } while (c.moveToNext());
                    // Define a new Adapter
                    // First parameter - Context
                    // Second parameter - Layout for the row
                    // Third parameter - ID of the TextView to which the data is
                    // written
                    // Forth - the Array of data

                    ArrayAdapter<String> adapter = new ArrayAdapter<String>(
                            getBaseContext(), android.R.layout.simple_list_item_1,
                            android.R.id.text1, values);

                    // Assign adapter to ListView
                    lv1.setAdapter(adapter);

                }
            });

            b3.setOnClickListener(new OnClickListener() {

                @Override
                public void onClick(View arg0) {
                    // TODO Auto-generated method stub
                    db.execSQL("DELETE FROM Names");
                }
            });
        }

        @Override
        public boolean onCreateOptionsMenu(Menu menu) {
            // Inflate the menu; this adds items to the action bar if it is present.
            getMenuInflater().inflate(R.menu.activity_main, menu);
            return true;
        }

    }




and this is activity_main.xml -


<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    tools:context=".MainActivity" >

    <EditText
        android:id="@+id/editText1"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_alignParentLeft="true"
        android:layout_alignParentRight="true"
        android:layout_alignParentTop="true"
        android:ems="10"
        android:hint="Add" >

    </EditText>

    <Button
        android:id="@+id/button1"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_alignParentLeft="true"
        android:layout_below="@+id/editText1"
        android:layout_marginTop="18dp"
        android:text="@string/add" />

    <Button
        android:id="@+id/button2"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_alignBaseline="@+id/button1"
        android:layout_alignBottom="@+id/button1"
        android:layout_centerHorizontal="true"
        android:text="@string/show" />

    <Button
        android:id="@+id/button3"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_alignBaseline="@+id/button2"
        android:layout_alignBottom="@+id/button2"
        android:layout_alignParentRight="true"
        android:text="@string/del" />

    <ListView
        android:id="@+id/listView1"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_alignParentBottom="true"
        android:layout_alignParentLeft="true"
        android:layout_below="@+id/button1" >

    </ListView>

</RelativeLayout>

I think something wrong with

do {
     values[i] = c.getString(c.getColumnIndex("Name"));
     i++;
   }
while (c.moveToNext());

what is the problem now? Please Help.

How do I post it? I mean when I copy and paste it here in comment box, it is difficult to read. — Ajay Sainy
– Ajay Sainy, Commented Jan 28, 2013 at 5:35

wtsang02 · Accepted Answer · 2013-01-27 22:40:19Z

0

Try looping like this:

for (c.moveToFirst(); !c.isAfterLast(); c.moveToNext()) {
   values[i] = c.getString(c.getColumnIndex("Name"));
}

answered Jan 27, 2013 at 22:40

wtsang02

18.9k10 gold badges51 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Muhammad Raqib · Accepted Answer · 2016-01-13 19:57:51Z

0

I think you should try this code.

Cursor cursor = new Cursor();
cursor.moveToFirst();
do{
values[i++] = cursor.getString(cursor.getColumnIndex("name"));
}while(cursor.moveToNext());
cursor.close();

answered Jan 13, 2016 at 19:57

Muhammad Raqib

3443 silver badges13 bronze badges

Collectives™ on Stack Overflow

How to get data form SQLite database and display it in ListView

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related