Create a loop using associative arrays

Question

I want to put this in a loop because it needs to be repeated 6 times, is it true that using variable variables is a bad practice? Do I need associative arrays?

Basically the 'c1' inside the variable needs to progressively change into 'c2', 'c3'...etc

<?php if ($pm_c1_djwd !== '') { ?>

<div>
   <span style="width:<?php echo $pm_width_c1;?>%"></span>
   <span><?php echo $pm_description_c1; ?></span>
</div>

<?php } ?>

Many Thanks

It would help to know where these variables are coming from. — Niet the Dark Absol
– Niet the Dark Absol, Commented Jan 28, 2013 at 23:45
Why? The variables are echoing the right data, I only need to know how to change the number at the end of each variable into '_c2', '_c3', '_c4' dynamically so I don't have to repeat the same code 6 times — djwd
– djwd, Commented Jan 28, 2013 at 23:54
Why do you have 6*3 variables to begin with? Just use nested arrays. — Daedalus
– Daedalus, Commented Jan 28, 2013 at 23:55
Right. Any time you feel the need to do this, it's an indicator that you should be using normal indexed arrays. — Barmar
– Barmar, Commented Jan 29, 2013 at 0:17

Jeremy J Starcher · Accepted Answer · 2013-01-28 23:58:53Z

1

Why not try regular arrays?

<?php
// Warning: Typed raw in the textarea
$pm_width = array(100, 100, 100, 100, 100, 100);

$pm_description = array(
  "Gizmo",
  "Doodad",
  "Widget",
  "Dohicky",
  "Thing-me-a-bob",
  "Marvelous toy my father gave to me."
);

$pm_c1_djwd = "Snod";

if ($pm_c1_djwd !== '') {

  for ($i = 0; $i < count($pm_description); $i++) {
    $width = $pm_width[$i];
    $desc = $pm_description[$i];

    echo "<div>";    
    echo "<span style='width:${width}%'>$desc</span>";     
    echo '</div>';
    echo PHP_EOL;
  }
}
?>

answered Jan 28, 2013 at 23:58

Jeremy J Starcher

24k6 gold badges56 silver badges75 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

andho · Accepted Answer · 2013-01-29 00:07:25Z

1

Instead of having a variable for each field like $pm_description_c1, ..c2 and so on, put them in an associative array:

$pms = array(
    array('description' => 'your description', 'width' => '123px', 'djwd' = 'what'),
    array('description' => 'Second item', 'width' => '123px', 'djwd' = '')
);

Then loop through them:

<?php
foreach ($pms as $pm) {
    if ($pm['djwd' !== '') {
    ?>
        <div>
            <span style="width:<?php echo $pm['width'];?>%"></span>
            <span><?php echo $pm['description']; ?></span>
        </div>
    <?php
    }
}
?>

answered Jan 29, 2013 at 0:07

andho

1,1611 gold badge15 silver badges27 bronze badges

Comments

Green Black · Accepted Answer · 2013-01-28 23:55:34Z

0

You can use variable variables for the thing you are asking...

<?php
$i = 0;
while( $i < 6 ){
$i ++;

$variable = "pm_c".$i."_djwd";
$variable2 = "pm_description_c".$i."";

 if (isset($$variable) && $$variable != '') { ?>

<div>
   <span style="width:<?php echo $$variable;?>%"></span>
   <span><?php echo $$variable2; ?></span>
</div>

<?php } 
}

answered Jan 28, 2013 at 23:55

Green Black

5,0571 gold badge19 silver badges29 bronze badges

1 Comment

djwd Over a year ago

I think this is still the best solution for my case and it works fine. Thanks everyone

Collectives™ on Stack Overflow

Create a loop using associative arrays

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related