MVC 4 C# problems with my controller updating database

Question

I have an issue with my method that updates the database with user information. during HttpGet it uses a view model to ensure the integrity of the data, and in HttpPost, the data is passed back and is there. (ran some checks with breakpoints and everything was holding the correct user data that they should have been)

However, when I run my .Save() method, this information is not stored into the DB.

I've checked to see if its pointing to the correct database by changing the data manually, it comes up in a list view just fine. I'M missing something, just can't figure out what ><

Below is the code there is form data in all of the relevant view models, but it just doesn't save!

    [HttpPost]
    public ActionResult HouseCreate(CreateHouseViewModel viewModel)
    {

        if (ModelState.IsValid)
        {          
            var house = new House();
            house.address = viewModel.address;
            house.postCode = viewModel.postCode;
            house.noOfDisputes = viewModel.noOfDisputes;
            _db.Save();

          return RedirectToAction("House");
        }
        return View(viewModel);
    }

house is an object of my house database, modelled correctly with correct Primary keys in place (double checked this in the database viewer.) save calls:

void DataSources.Save()
    {
        SaveChanges();
    }

No errors come up, which makes it even worse.

Well, you don't seem to be adding your "house" to your database anywhere. You're just create a new House and calling Save. What is Save() anyways? It's not Entity Framework, as that is SaveChanges(). — Erik Funkenbusch
– Erik Funkenbusch, Commented Jan 29, 2013 at 18:38

BrunoLM · Accepted Answer · 2013-01-29 18:42:38Z

4

using (var context = new UnicornsContext())
{
    var unicorn = new Unicorn { Name = "Franky", PrincessId = 1};

    context.Unicorns.Add(unicorn); // your missing line

    context.SaveChanges();
}

Source

answered Jan 29, 2013 at 18:42

BrunoLM

101k86 gold badges311 silver badges464 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dan Saltmer · Accepted Answer · 2013-01-29 18:40:13Z

0

Your "_db" object, I assume is entity framework. This will have a collection on it, maybe _db.Houses ? You need to add the object to that.

answered Jan 29, 2013 at 18:40

Dan Saltmer

2,16514 silver badges15 bronze badges

1 Comment

Jay Over a year ago

This points back to my DataSources class which holds IQueryable collections of all the tables i'll be querying, when i specify the Houses database though, I can't seem to call the save method. I'm missing something obvious I can feel it.

ajawad987 · Accepted Answer · 2013-01-29 19:26:30Z

0

Since it appears you are using Entity Framework, you'll need to inform Entity Framework that your model has been updated. Inbetween the HttpGet and the HttpPost methods, the model becomes dissassociated from the database context. I think the following code work to re-attach it to the context so you can save the changes:

context.Entry(myEntity).State = EntityState.Modified;
context.MyEntities.Attach(myModel);
context.SaveChanges();

Edit: Forgot to add the re-attach method part, assuming this is an existing record in the DB that your updating.

edited Jan 29, 2013 at 19:26

answered Jan 29, 2013 at 19:05

ajawad987

4,6922 gold badges30 silver badges49 bronze badges

Comments

Inari · Accepted Answer · 2013-01-29 19:55:04Z

0

This I find is a far more reliable means to adding items to the database:

// Note: db is your dbContext, model is your view model

var entity = db.Entry(model); // Required to attach the entity model to the database
                              //   you don't need the "var entity = " but its useful
                              //   when you want to access it for logging
db.Entry(model).State = EntityState.Added; // Required to set the entity as added - 
                                           //   modified does not work correctly

db.SaveChanges();             // Finally save

answered Jan 29, 2013 at 19:55

Inari

5543 silver badges14 bronze badges

Collectives™ on Stack Overflow

MVC 4 C# problems with my controller updating database

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related