How to make javascript code clearer?

Question

I have five star rating and average score.

Average score is float number

Five star rating just 10 section, one star have two half star (so 10 section is five star)

Ex:

Average score is: from 0 - 5 (average = 4.658, or average = 0.256, 0 <= average <= 5)

Five star rating is 10 section: [0, 0.5, 1, 1.5, 2, 2.5, 3, 3.5, 4, 4.5, 5]

How to check and set average score to 10 section base on average score?

This is my code, it very long.

            var twofixed = Math.round(average * 100) / 100;           
            twofixed = Math.abs(twofixed);
            var decimal = twofixed - Math.floor(twofixed)

            twofixed = (twofixed + "").split(".");

            if(twofixed[0] == 0)
            {
                if(twofixed[1] == undefined) { average = 0; }
                else
                {
                    if(twofixed[1] <= 99)
                    {
                        average = 0.50;
                    }
                    else
                    {
                        average = 1;
                    }
                }
            }
            else if(twofixed[0] == 1)
            {
                if(twofixed[1] == undefined) { average = 1; }

                else
                {
                    if(twofixed[1] <= 99)
                    {
                        average = 1.50;
                    }
                    else
                    {
                        average = 2;
                    }
                }
            }
            else if(twofixed[0] == 2)
            {
                if(twofixed[1] == undefined) { average = 2; }
                else
                {
                    if(twofixed[1] <= 99)
                    {
                        average = 2.50;
                    }
                    else
                    {
                        average = 3;
                    }
                }
            }
            else if(twofixed[0] == 3)
            {
                if(twofixed[1] == undefined) { average = 3; }
                else
                {
                    if(twofixed[1] <= 99)
                    {
                        average = 3.50;
                    }
                    else
                    {
                        average = 4;
                    }
                }
            }
            else if(twofixed[0] == 4)
            {
                if(twofixed[1] == undefined) { status = 'Great'; average = 4; }
                else
                {
                    if(twofixed[1] <= 99)
                    {
                        average = 4.50;
                    }
                    else
                    {
                        average = 5;
                    }
                }                    
            }
            else if(twofixed[0] == 5)
            {
                if(twofixed[1] == undefined) { average = 5; }
            }

Big thanks to @th3falc0n with small code, I write more than 50 line of code, but you can do with one line of code to solve of my long code.

Thanks everyone to help me, and sorry for unclearly question and bad english

Average is the average of rating. Ex: I have 5 user, every user have one rating, then average = 5/5 = 1 — Garu Jwon
– Garu Jwon, Commented Jan 30, 2013 at 8:28

T.J. Crowder · Accepted Answer · 2013-01-30 07:53:44Z

3

If I understand your question correctly, you want to take an average score and convert that into a star rating where each star is worth two points, and you're starting with average which appears to be a fractional number between 0 and 5.

If so:

// Flags for whether to show stars, based on `average` being
// a fractional number `0 <= average < 5`
var stars = [
    average > 0,
    average > 1,
    average > 2,
    average > 3,
    average > 4
];

Those are flags. Use stars[0] to decide whether to show the first star, stars[1] to decide whether to show the second, etc.

If your average is actually between 0 and 10, then just adjust the numbers accordingly:

// Flags for whether to show stars, based on `average` being
// a fractional number `0 <= average < 10`
var stars = [
    average > 0,
    average > 2,
    average > 4,
    average > 6,
    average > 8
];

edited Jan 30, 2013 at 7:53

answered Jan 30, 2013 at 7:27

T.J. Crowder

1.1m201 gold badges2k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

th3falc0n Over a year ago

His code uses 10 steps but you are only providing 5 flags. Please change that.

T.J. Crowder Over a year ago

@th3falc0n: He talks about five stars, so that's what I did. Until/unless the question is clarified... :-)

Garu Jwon Over a year ago

thanks for you instruction, but it not just integer number. I have Five Star, every star have two half star, but average number is float, so i want to make average fix to 10 section in five star.

Garu Jwon Over a year ago

Thanks, you anwser another question of me. Sorry for my bad question and bad english

th3falc0n · Accepted Answer · 2013-01-30 07:37:19Z

1

I think you just need

Math.floor(average * 2.0) / 2.0;

This code leaves only x.y from any float number.

Edit: I made a little mistake. I set it to 0.1 steps so it would make 0.85 to 0.8, that is fixed now (1/2.0) = 0.5 steps. You can use 4.0 for 0.25 steps 10.0 for 0.1 and so on.

edited Jan 30, 2013 at 7:37

answered Jan 30, 2013 at 7:31

th3falc0n

1,4372 gold badges13 silver badges33 bronze badges

3 Comments

Garu Jwon Over a year ago

The 'average' just from 0 - 5, but it a decimal number, i want fix it to 10 section, [0, 0.5, 1, 1.5, 2, 2.5, 3, 3.5, 4, 4.5, 5]. Ex: If average = 4.69 then it will 4.5 in 10 section

th3falc0n Over a year ago

That is exactly what my code does. It makes 0.12 to 0, 0.54 to 0.5, 1.499 to 1 an so on.

Garu Jwon Over a year ago

Oh, very simple. Sorry I just again and it work perfect, very small but very effective, thank you so much

zozo4kin · Accepted Answer · 2013-01-30 07:32:31Z

0

function getAverage(twofixed)
        {
            var average;
            if(twofixed[1] == undefined)
            {
                average = twofixed[0];
            }
            else
            {
                average = (twofixed[1] <= 99) ? twofixed[0]+0.50 : twofixed[0]+1;
            }
            return average;
        }

answered Jan 30, 2013 at 7:32

zozo4kin

11 silver badge2 bronze badges

Collectives™ on Stack Overflow

How to make javascript code clearer?

3 Answers 3

4 Comments

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related