How to prevent execution of controller actions based on condition?

Question

I have a controller with many actions. I need to prevent execution of some actions based on this condition:

if (Session["MyObject"] == null) return RedirectToAction("Introduction");

It should redirect to a default Introduction action.

I can put this condition in each action, but I would like to define this condition just in one place, like in controller's constructor maybe.

Any ideas? Thank you.

2 ideas. Custom Authorization filter or custom Action Filter. You can either populate the filter with logic that decides which action is affected or by which actions you apply the filter — Dave Alperovich
– Dave Alperovich, Commented Jan 30, 2013 at 17:57
I am a Java programmer so I could be wrong but wouldn't putting the code snippets you presented in the constructor result in all actions being redirected to the default introduction? — Chetan Kinger
– Chetan Kinger, Commented Jan 30, 2013 at 18:04
Sure, I need to distinguish between actions. I guess Dave's advice is correct. let me check.. — Slava
– Slava, Commented Jan 30, 2013 at 18:08
Only if the session object is empty. I assume the goal is to populate the session if it expires — Dave Alperovich
– Dave Alperovich, Commented Jan 30, 2013 at 18:10
Not really. The session object is not set automatically, there is some specific app logic for that. Doesnt matter ;) Thanks Dave, the ActionFilterAttribute suggestion is perfect !! — Slava
– Slava, Commented Jan 30, 2013 at 18:24

Community · Accepted Answer · 2013-05-16 21:23:09Z

7

This is a quick mock up, but I think the idea holds

public class CheckSessionFilterAttribute : ActionFilterAttribute
{
    public override void OnActionExecuting(ActionExecutingContext filterContext)
    {
        if (filterContext.HttpContext.Session["MyObject"] == null)
        {
            // redirect must happen OnActionExecuting (not OnActionExecuted)
            filterContext.Result = new RedirectToRouteResult(
              new System.Web.Routing.RouteValueDictionary {
              {"controller", "Tools"}, {"action", "CreateSession"}

        }
        base.OnActionExecuting(filterContext);
    }   
}

edited May 16, 2013 at 21:23

CommunityBot

11 silver badge

answered Jan 30, 2013 at 18:16

Dave Alperovich

32.6k8 gold badges82 silver badges101 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to prevent execution of controller actions based on condition?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related