Comparing arrays in c# based on user input

Question

Trying to compare 2 arrays but not getting it to work

            Console.WriteLine("Entering elements for ths 1st array: ");
        int[] arr1 = new int[3];
        for (int i = 0; i < arr1.Length; i++)
        {
            arr1[i] = Convert.ToInt32(Console.ReadLine());
        }
        Console.WriteLine("Entering the elements for the 2nd array: ");
        int[] arr2 = new int[3];
        for (int i = 0; i < arr2.Length; i++)
        {
            arr2[i] = Convert.ToInt32(Console.ReadLine());
        }
        bool result = Array.Equals(arr1,arr2);
        if (result)
        {
            Console.WriteLine("Equal");
        }
        else
        {
            Console.WriteLine("Not equal");
        }
    }

I keep on getting a Not equal

possible duplicate of Testing Equality of Arrays in C#

ChrisWue
– ChrisWue

2013-02-01 20:32:50 +00:00
Commented Feb 1, 2013 at 20:32 — ChrisWue
– ChrisWue, Commented Feb 1, 2013 at 20:32

Anthony · Accepted Answer · 2013-02-01 20:35:41Z

3

This doesn't work because Array.Equals() runs Object.Equals method - it compares just references. Use Enumerable.SequenceEqual() instead for example.

answered Feb 1, 2013 at 20:35

Anthony

5103 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

epitka · Accepted Answer · 2013-02-01 20:32:44Z

0

That will never work. These are two different instances of the array. Equals is inherited from Object.

answered Feb 1, 2013 at 20:32

epitka

17.6k21 gold badges91 silver badges146 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 11:48:50Z

0

I think you are comparing two obect containers for equality - see this post... What's the fastest way to compare two arrays for equality? you need to compare the contents.

edited May 23, 2017 at 11:48

CommunityBot

11 silver badge

answered Feb 1, 2013 at 20:33

Jay

10.2k8 gold badges56 silver badges74 bronze badges

Comments

Steve · Accepted Answer · 2013-02-01 20:37:23Z

0

You are not comparing the values stored in the arrays but you are comparing two different instances of an integer array. (the references).
Of course they are different.

If you want to check only if the two arrays contains the same values you could use the SequenceEquals LinQ operator, if you wish to get the difference between the two arrays use Except

if(arr1.SequenceEquals(arr2))
     Console.WriteLine("Equals");
else
     Console.WriteLine("Not equal");

....

int[] diff =  arr1.Except(arr2).ToArray();
if(diff.Length == 0) 
     Console.WriteLine("Equals");
else
     Console.WriteLine("Not equal");

edited Feb 1, 2013 at 20:37

answered Feb 1, 2013 at 20:32

Steve

217k22 gold badges242 silver badges296 bronze badges

2 Comments

Servy Over a year ago

If you're going to use LINQ, just use SequenceEqual. It can short circuit, unlike Except. It also is shorter, and semantically represents what you want to do. Oh, and Except doesn't return an array, it returns an IEnumerable<T>, and so you'd need to use Count, or better yet, Any, instead of Length.

Steve Over a year ago

@Servy OMG you are fast. wait

Collectives™ on Stack Overflow

Comparing arrays in c# based on user input

4 Answers 4

Comments

Comments

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related