Regular expression java pattern doesn't validate?

Question

The regular expression, "String regex = "[0-9a-z]+@[0-9a-z]+.+[0-9a-z]";" , is used for testing a email validation. Basically, im trying to make it so that an email will only match this patter if the email begins with a string of alphanumeric chars, followed by 1 @ symbol, followed by another string of alphanumeric chars, followed by 1 ., and then finally a string of alphanumeric chars. Whats failing is that when i enter an email without a string of alphanumerics after the last ., the program will still match with the regex string. How do i make it so that there MUST be another string of alphanumerics after the .? The whole code is:

import java.util.Scanner;
import java.util.regex.*;

public class Regex
{   
    public static void main (String[]args){

        Scanner input = new Scanner(System.in);
        System.out.println("Please enter your Email");
        String mail = input.nextLine();

        String regex = "[0-9a-z]+@[0-9a-z]+.+[0-9a-z]";

        Pattern p = Pattern.compile(regex);
        Matcher m = p.matcher(mail);

        if(m.find()) {
            System.out.println("VALID");
        } else {
            System.out.println("INVALD");
        }
    }
}

.+ will give you "at least one arbitrary character". I think you meant to have the "+" after the last brackets. — G. Bach
– G. Bach, Commented Feb 3, 2013 at 17:32
For this kind of problems, regexper.com is my tool of choice. — Petr Janeček
– Petr Janeček, Commented Feb 3, 2013 at 17:32
Your regular expression for email addresses is very restrictive. For example british email addresses @example.co.uk would not validate. nor would email addresses with . or + in the user part. Check out blog.gerv.net/2011/05/html5_email_address_regexp for a better one (still not the full spec, but closer. — Charlie
– Charlie, Commented Feb 3, 2013 at 17:44
You shouldn't use regular expressions to validate email addresses. — David Conrad
– David Conrad, Commented Feb 3, 2013 at 18:13

Sergey Kalinichenko · Accepted Answer · 2013-02-03 17:38:48Z

4

An unescaped . in the expression stands for any character. You need to use either \\., or [.] to match a literal dot.

String regex = "[0-9a-z]+@[0-9a-z]+[.]+[0-9a-z]";

The + after the dot means "one or more occurrences of the prior expression". Above, the "prior expression" is a single dot. To match multiple segments in the e-mail's domain address, you need to add parentheses:

String regex = "[0-9a-z]+@([0-9a-z]+[.])+[0-9a-z]+";

edited Feb 3, 2013 at 17:38

answered Feb 3, 2013 at 17:30

Sergey Kalinichenko

729k85 gold badges1.2k silver badges1.6k bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

G. Bach Over a year ago

I think the OP forgot a "+" after the last set of brackets; i doubt he wants the address to end in one dot followed by one alphanumeric.

Sergey Kalinichenko Over a year ago

@G.Bach You're right, there was no plus at the end. This is now fixed.

David Conrad Over a year ago

He also didn't want multiple segments in the e-mail's domain address, even though they are perfectly valid. Regular expressions should never be used to validate email addresses under any circumstances whatsoever. It's horribly wrong.

G. Bach Over a year ago

@DavidConrad Why is that? Aren't email addresses a regular language?

David Conrad Over a year ago

Perhaps just barely, but they have so many rules and exceptions that a proper regex to match them, if it's even possible, would fill an entire sheet of A4 paper and be totally incomprehensible and unmaintainable. But people always start out thinking "It's easy, I know what an email address looks like" and then they write something like the above that excludes tons of perfectly valid email addresses. (Valid per RFC 2822, that is.)

DangerDan · Accepted Answer · 2013-02-03 18:04:32Z

1

A slightly better regex would include start of line ^ and end of line $ anchors.

Otherwise it will only need to match a single instance of a valid email in the string and it will pass. Also, instead of the plus sign to indicate 1 or more, you could restrict it to 2 to 4 characters by adding {2,4}. Without these in place something like

[email protected]@thisIsOdd.helloworld.anythingelse

will erroneously be valid.

String regex = "^[0-9a-z]+@([0-9a-z]+[.])+[0-9a-z]{2,4}$";

answered Feb 3, 2013 at 18:04

DangerDan

5292 silver badges14 bronze badges

Collectives™ on Stack Overflow

Regular expression java pattern doesn't validate?

2 Answers 2

5 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related