PHP - remove comma from the last loop

Question

I have a PHP while LOOP, and I want to remove last comma , from echo '],'; if it is last loop

            while($ltr = mysql_fetch_array($lt)){
                echo '[';
                echo $ltr['days']. ' ,'. $ltr['name'];
                echo '],';
            }

do not use mysql_*. try PDO::

Danilo Kobold
– Danilo Kobold

2013-02-05 06:20:15 +00:00
Commented Feb 5, 2013 at 6:20 — Danilo Kobold
– Danilo Kobold, Commented Feb 5, 2013 at 6:20

Eric Hotinger · Accepted Answer · 2013-02-05 06:17:34Z

7

Create an array with the elements as you go along so that they look like array = ([ELEMENT INFO], [ELEMENT INFO], [ELEMENT INFO]) and then implode the array with a comma.

answered Feb 5, 2013 at 6:17

Eric Hotinger

9,3965 gold badges39 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

leftclickben Over a year ago

This method produces the nicest code and I don't have any reason to think it will be less efficient than any other, less elegant methods, with the possible exception of if there are a huge number of elements.

Yogesh Suthar · Accepted Answer · 2013-02-05 06:19:05Z

6

$str = '';
while($ltr = mysql_fetch_array($lt)){
    $str .= '[';
    $str .= $ltr['days']. ' ,'. $ltr['name'];
    $str .= '],';
}

echo rtrim($str, ",");

this will remove the last , from string

answered Feb 5, 2013 at 6:19

Yogesh Suthar

30.5k18 gold badges75 silver badges100 bronze badges

Comments

Filip Halaxa · Accepted Answer · 2013-10-13 09:32:40Z

4

I think the systemic solution is following:

$separator = '';
while($ltr = mysql_fetch_array($lt)){
    echo $separator;
    echo '[';
    echo $ltr['days']. ' ,'. $ltr['name'];
    echo ']';
    if (!$separator) $separator = ', ';
}

No call for count(), no additional iteration of implode(), no additional string operations, ready for any (unpredictable) number of results.

edited Oct 13, 2013 at 9:32

answered Oct 11, 2013 at 8:57

Filip Halaxa

7786 silver badges14 bronze badges

Comments

user1959825 · Accepted Answer · 2013-02-05 06:19:38Z

3

$result = mysql_fetch_array($lt);
for ($i=0;$i<=(count($result)-1);$i++) {
    $ltr = $result[$i];
    echo '[';
    echo $ltr['days']. ' ,'. $ltr['name'];
    echo ']';
    if(!count($result)-1 == $i){
        echo ',';
    }
}

answered Feb 5, 2013 at 6:19

user1959825

1 Comment

Abdullah Shaikh Over a year ago

I like this answer instead of using rtrim as you don't have to maintain a string the size of which depends on loop.

d4Rk · Accepted Answer · 2013-02-05 06:19:10Z

1

Check how many entries you have, make a "Counter" and a condition to only put the comma when its not the last loop.

answered Feb 5, 2013 at 6:19

d4Rk

6,7096 gold badges49 silver badges64 bronze badges

Comments

drodil · Accepted Answer · 2013-02-05 06:40:10Z

1

$arr = array();
while($ltr = mysql_fetch_array($lt)){
    $arr[] = '[' . $ltr['days'] . ' ,' . $ltr['name'] . ']';
}

echo implode(',', $arr);

answered Feb 5, 2013 at 6:40

drodil

2,3311 gold badge23 silver badges43 bronze badges

Comments

Prasanth Bendra · Accepted Answer · 2013-02-05 06:43:45Z

1

$res_array = array();

while($ltr = mysql_fetch_array($lt)){
   $res_array[] = '['.$ltr['days']. ' ,'. $ltr['name'].']';
}

$str = implode(",",$res_array);
echo $str;

answered Feb 5, 2013 at 6:43

Prasanth Bendra

33.1k9 gold badges56 silver badges74 bronze badges

1 Comment

Prasanth Bendra Over a year ago

mysql_* is deprecated, use mysqli OR PDO

Chris Christensen · Accepted Answer · 2013-02-05 06:44:37Z

1

Save the response as a var instead of echoing it and then remove the final character at the end using substr.

      $response = "";
       while($ltr = mysql_fetch_array($lt)){
            $response .= '[';
            $response .= $ltr['days']. ' ,'. $ltr['name'];
            $response .= '],';
        }
      echo substr($response, 0, -1);

answered Feb 5, 2013 at 6:44

Chris Christensen

4182 silver badges6 bronze badges

Comments

Syed Ahmad Murtaza · Accepted Answer · 2016-10-28 10:35:01Z

0

//this one works
$result = mysql_fetch_array($lt);
for ($i=0;$i<=(count($result)-1);$i++) {
    $ltr = $result[$i];
    echo '[';
    echo $ltr['days']. ' ,'. $ltr['name'];
    echo ']';
    if(count($result)-1 != $i){
        echo ',';
    }
}

answered Oct 28, 2016 at 10:35

Syed Ahmad Murtaza

1

Collectives™ on Stack Overflow

PHP - remove comma from the last loop

9 Answers 9

1 Comment

Comments

Comments

1 Comment

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

9 Answers 9

1 Comment

Comments

Comments

1 Comment

Comments

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related