Using a JS Variable with .attr()

Question

This should be simple - I want to use a javascript variable, 'foo' within the .attr() element as below:

$("#readreplytxt_" + msgid).attr("onClick", "readofferclose(foo)");

I've tried this:

$("#readreplytxt_" + msgid).attr("onClick", "readofferclose("+ foo")");

However no joy.

How can I make this work?

Why are you trying to do this instead of just calling .click()? — Jon
– Jon, Commented Feb 5, 2013 at 14:33
"readofferclose(" + foo + ")" But why not just apply .on("click", function() { })? — Antony
– Antony, Commented Feb 5, 2013 at 14:33
The console tells you what's wrong with "readofferclose("+ foo")". — Felix Kling
– Felix Kling, Commented Feb 5, 2013 at 14:33

Nope · Accepted Answer · 2013-02-05 14:36:05Z

5

If you are already using a script to assign the click why not use the click() method to bind the event, similar ot this:

$("#readreplytxt_" + msgid).click(function(){
    readofferclose(foo);
});

It will make your javascript nice and unobtrusive too.

edited Feb 5, 2013 at 14:36

answered Feb 5, 2013 at 14:32

Nope

22.4k8 gold badges50 silver badges73 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

Steve_M Over a year ago

Basically its a hide/show button, so when the function to show the elements is ran it changes the function ran by the button to the hide function, however each of these functions needs the foo variable passed to them.

Aaron Digulla Over a year ago

+1 This code will create a hidden reference to foo, so the function will see the current value when it will eventually be called.

Aaron Digulla Over a year ago

If you create a new foo variable for each element, then this works.

idmean Over a year ago

@Steve_M If you build a hide/show button you maybe will intrested on .toggle() Documentation Toggle

Nope Over a year ago

@Steve_M: One approach could be to use 2 classes and use toggleClass(). Or you can use .css("height", "20px"), changing the value 20px for what you need.

|

DSharper · Accepted Answer · 2013-02-05 14:33:33Z

1

Note you are missing "+" sign.

$("#readreplytxt_" + msgid).attr("onClick", "readofferclose("+ foo + ")");

answered Feb 5, 2013 at 14:33

DSharper

3,2279 gold badges32 silver badges47 bronze badges

Comments

Jesper · Accepted Answer · 2013-02-05 14:34:01Z

1

Attach an event handler instead:

$("#readreplytxt_" + msgid).click(function (event) {
    event.preventDefault(); // prevent the default click action
    readofferclose(foo);
});

answered Feb 5, 2013 at 14:34

Jesper

7,6454 gold badges43 silver badges58 bronze badges

Collectives™ on Stack Overflow

Using a JS Variable with .attr()

3 Answers 3

9 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

9 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related