How to make delay in calling a function in javascript?

Question

I want to execute a particular number of statements after some delay. For eg:

function findPosX(obj) {
    var curleft = 0;
    if (obj.offsetParent) {
        while (1) {
            curleft += obj.offsetLeft;
            if (!obj.offsetParent) {
                break;
            }
            obj = obj.offsetParent;
        }
    } else if (obj.x) {
        curleft += obj.x;
    }
    return curleft;
}

function findPosY(obj) {
    var curtop = 0;
    if (obj.offsetParent) {
        while (1) {
            curtop += obj.offsetTop;
            if (!obj.offsetParent) {
                break;
            }
            obj = obj.offsetParent;
        }
    } else if (obj.y) {
        curtop += obj.y;
    }
    return curtop;
}
function gotoDiv(index) {
    var ele = document.getElementById("Div" + index);
    var x = findPosX(ele);
    var y = findPosY(ele);
    setTimeout("window.scrollTo(x, y)", 5000);
}

Here I want to set the current scroll position to a prticular div. But it's giving me error: x is undefined. Let me tell u if I use the functions as below it works fine, so please don't tell me that ele is null and blah blah blah.

function gotoDiv(index) {
    var ele = document.getElementById("Div" + index);
    var x = findPosX(ele);
    var y = findPosY(ele);
    window.scrollTo(x, y);
}

Any help appreciated.

ele being null probably won't cause the x being undefined, I think natrium has that solution, but you should check ele for null though ;) i'm sure you've just simplified the code here and you're actually doing it in your code already ;) — dharga
– dharga, Commented Sep 25, 2009 at 12:57

Brian Dukes · Accepted Answer · 2009-09-25 12:55:50Z

14

You can give setTimeout a function, rather than a string, which will let you access those variables:

setTimeout(function() { window.scrollTo(x, y); }, 5000);

answered Sep 25, 2009 at 12:55

Brian Dukes

157k25 gold badges152 silver badges176 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Natrium · Accepted Answer · 2009-09-25 13:03:20Z

4

~~try~~

~~setTimeout("window.scrollTo(" + x + ", " + y + ")", 5000);~~

this is not best practice. Use this in stead:

setTimeout(function() { window.scrollTo(x, y); }, 5000);

edited Sep 25, 2009 at 13:03

answered Sep 25, 2009 at 12:52

Natrium

31.3k19 gold badges62 silver badges79 bronze badges

3 Comments

SolutionYogi Over a year ago

Do not pass JS code as string to setTimeout function. Please pass a regular javascript function.

Crescent Fresh Over a year ago

Way to rip bdukes' answer after the fact.

Natrium Over a year ago

at least I admit my original answer was not the best one. bdukes is geting more votes so no worries.

Evernoob · Accepted Answer · 2009-09-25 12:52:19Z

1

Wrap the function in a closure and then put the timeout inside the closure.

answered Sep 25, 2009 at 12:52

Evernoob

5,5718 gold badges39 silver badges50 bronze badges

1 Comment

Manish Over a year ago

already tried that but what if the function requires a paramter?? It's giving the current error bcoz of the same reason..!!

Collectives™ on Stack Overflow

How to make delay in calling a function in javascript?

3 Answers 3

Comments

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related