Random background in php and css

Question

So I am trying to get it do it will choose either 1.jpg 2.jpg or 3.jpg. My guess is I am doing this wrong but I am getting no php errors nor is my IDE telling my that my CSS is wrong, so I have nothing to go on.

Code:

HTML/CSS:

<html>
    <head>
        <link rel="stylesheet" href="css/styles.css" type="text/css" media="all">
        <script type="text/javascript" src="js/jquery-1.4.2.min.js" ></script>
        <?php
            include 'php/backgorundlogic.php';
        ?>
        <style>
            body {
                background:url($bgset);
                background-size:cover;
            }
        </style>
    </head>
    <body>
        <div class="container">
            <input class="searchbar" type="text" />
        </div>
    </body>
</html>

PHP:

<?php
    $rbg = mt_rand(1, 3);
    $ext = '.jpg';

    $bgset = 'img/' + $rbg + $ext;
?>

DEMO: here

Just checking, did you intend to include backgorundlogic.php, or backgroundlogic.php? — Chris Forrence
– Chris Forrence, Commented Feb 8, 2013 at 21:05

adamdehaven · Accepted Answer · 2013-02-08 22:12:35Z

4

use . instead of +

<?php
    $rbg = mt_rand(1, 3);
    $ext = '.jpg';

    $bgset = 'img/' . $rbg . $ext;
?>

and change this line

    <style>
        body {
            background:url(<?php echo $bgset; ?>);
            background-size:cover;
        }
    </style>

edited Feb 8, 2013 at 22:12

adamdehaven

5,92010 gold badges64 silver badges84 bronze badges

answered Feb 8, 2013 at 21:05

Ali Akbar Azizi

3,5654 gold badges31 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

cdhowie Over a year ago

+1 This is indeed another problem. However, consider explaining the difference between the two operators for the OP's benefit.

cdhowie · Accepted Answer · 2013-02-08 21:03:55Z

2

This line:

background:url($bgset);

Should be this:

background:url(<?php echo $bgset ?>);

Right now the PHP engine is passing $bgset through as plain text since it is not in a PHP script context. You might consider being a bit more future-proof and HTML-escape the value as well:

background:url(<?php echo htmlspecialchars($bgset) ?>);

answered Feb 8, 2013 at 21:03

cdhowie

172k25 gold badges303 silver badges324 bronze badges

2 Comments

user2014751 Over a year ago

How do I set two answers as the answer?

cdhowie Over a year ago

@user2014751 You can't. In this case it may be appropriate to refrain from selecting a correct answer unless it addresses all of your problems.

ssaltman · Accepted Answer · 2013-12-04 00:40:44Z

0

 background: url('<?php $a = array(‘anyfile.jpg’,'anyotherfile.gif’, ‘somefile.png’); echo $a[array_rand($a)];?>');

or if your image names conform to something with an integer on the end, eg. clouds3.png

 background: url('/images/lm/clouds<?php echo rand(0,10)?>.png') ;

answered Dec 4, 2013 at 0:40

ssaltman

3,7231 gold badge20 silver badges21 bronze badges

Collectives™ on Stack Overflow

Random background in php and css

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related