setting variables in javascript

Question

I need to create on snippet of javascript that, based on an A tags id, the window will navigate to the proper html file. I've got something together that when I look at it, it should work but for some reason it doesnt. Here's what I got.

<script> 
    $(document).bind('pageinit', function() { 
        $('a').each(function (index){
            var elementId = $(this).attr("id"); 
            elementId= elementId + '.html';
            $(function(){ 
                $(elementId).click(function (event) { 
                    event.preventDefault(); 
                    window.location.assign(elementId); 
                }); 
            }); 
        });
    }); 
</script>

This part is so that I can load an external html in an ios web app with out exiting the web app window

$(function(){ $(elementId).click(function (event) { 
    event.preventDefault(); 
    window.location.assign(elementId);

Did I write the variable wrong some how? Any help would be appreciated

Could you fix the indentation in your code sample? It's hard to tell what's really going on when it's formatted like this. — millimoose
– millimoose, Commented Feb 13, 2013 at 17:19
The DOM ready function is there to run the code when my first page is loaded. It may not be the proper way to do it, but I have a variation of this where there is no variable and it works fine. — mhartington
– mhartington, Commented Feb 13, 2013 at 17:24

adeneo · Accepted Answer · 2013-02-13 17:35:12Z

2

I'll take a wild guess:

$(function(){ 
    $('a').on('click', function(e) {
        e.preventDefault();
        window.location.assign(this.id + '.html'); 
    });
});

edited Feb 13, 2013 at 17:35

answered Feb 13, 2013 at 17:23

adeneo

319k29 gold badges410 silver badges392 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Robert Beuligmann Over a year ago

Just to be clear, this would replace all of his script and not just the inner portion he highlighted, correct?

mhartington Over a year ago

Awesome, it works. Only had to change the 'a.html' to 'a' but it works. Thanks alot

Reinstate Monica Cellio · Accepted Answer · 2013-02-13 17:26:33Z

1

This is a simplified version of what you have there...

<script>
    $(function() {
        $("a").on("click", function(e) {
            e.preventDefault();
            window.location.href = this.id + ".html";
        });
    });
</script>

answered Feb 13, 2013 at 17:26

Reinstate Monica Cellio

26.2k6 gold badges54 silver badges67 bronze badges

Collectives™ on Stack Overflow

setting variables in javascript

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related