Issue i'm facing ; Javascript encode with php variables inside

Question

I seem to be having an issue, I have a Javascript code,and it contains php variables

<?php   // Database information 
$name="whatever"; 

$mp3 = "Link/to/track/";
echo "
var myPlaylist = [{
    mp3:'mix/4.mp3',
    title:'$name',
}]]; </script>";

Upon trying to encode this,I'm able to encode the Javascript part, but it displays my variable names (in this instance $name) instead of the value(whatever)

It is of course inside a .php file, as .js files are not parsed by PHP as default (you can set it to parse them). — adeneo
– adeneo, Commented Feb 16, 2013 at 1:15
Your PHP code is fine but I can't help but to notice that the Javascript isn't. — Heap
– Heap, Commented Feb 16, 2013 at 1:26
Your code is ugly but works fine on my computer , not sure what you are talking about when you say encode. — mpm
– mpm, Commented Feb 16, 2013 at 1:37

Colin M · Accepted Answer · 2013-02-16 01:36:20Z

2

Whenever you're transferring information between PHP and JS like this, use json_encode. 1) You know that you're building a proper JavaScript structure (in your code, you're not...you're closing the array twice), and 2) you protect from escaping issues. Try:

<?php
$name = 'whatever';
$mp3 = '/link/to/track';

$json = array(array('mp3' => $mp3, 'title' => $name));
print "var myPlaylist = " . json_encode($json);

answered Feb 16, 2013 at 1:36

Colin M

13.4k3 gold badges42 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Danny · Accepted Answer · 2013-02-16 01:14:46Z

0

That should work, but try this anyway

title:'".$name."',

or

title:'{$name}',

Since you used double quotes it should render php variables, single quotes wouldn't but you are not using those. Also make sure to escape the name because what if it had a single quote in it? It would break your javascript (unless its strictly controlled and you know for a fact it will not have a single quote in it).

answered Feb 16, 2013 at 1:14

Danny

1,1952 gold badges13 silver badges34 bronze badges

3 Comments

X_Mystico Over a year ago

Neither of them worked, it returned back :$name instead of the value

Danny Over a year ago

Are you sure php is running? Start a new page with just this code and see what happens. <?php echo time(); ?> Do you see a big number or the code when the page loads?

X_Mystico Over a year ago

Php's running fine, as the same page, houses all my php connector information

Collectives™ on Stack Overflow

Issue i'm facing ; Javascript encode with php variables inside

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related