C# MVC Class Object reference not set to an instance of an object

Question

Can anyone help me get around my problem with my class please?

I have an Address class:

public class Address
{
    public string addressDescription { get; set; }
    public string addressNumber { get; set; }
    public string adddressLine1 { get; set; }
    public string adddressLine2 { get; set; }
    public string adddressLine3 { get; set; }
    public string addressPostCode { get; set; }
    public double addressLatitude { get; set; }
    public double addressLongitude { get; set; }
}

And I have a Route Class:

public class Route
{
    public Address from { get; set; }
    public Address to { get; set; }
}

And in my controller i have setup some dummy information like this:

public ActionResult FareCalculator(string from , string to)
    {

        var myroute = new Route();

        myroute.from.addressDescription = from;
        myroute.from.addressLatitude = 51.481581;
        myroute.from.addressLongitude = -3.179090;
        myroute.to.addressDescription = to;
        myroute.to.addressLatitude = 51.507335;
        myroute.to.addressLongitude = -0.127683;

        return View(myroute);
    }

but when i run the project it falls over on the myroute.from.addressDescription = from; line saying Object reference not set to an instance of an object.

I cannot see what I am doing wrong. Can anyone help please?

Thanks

Trev

The correct answers are below, but you should consider renaming route to something else. Route means something in MVC. — Brian P
– Brian P, Commented Feb 17, 2013 at 14:24

Darren · Accepted Answer · 2013-02-17 14:15:08Z

3

You need to create a new instance of Address and assign it to from and to:

public ActionResult FareCalculator(string from , string to)
{

    var myroute = new Route();
    myroute.from = new Address(); // new instance
    myroute.from.addressDescription = from;
    myroute.from.addressLatitude = 51.481581;
    myroute.from.addressLongitude = -3.179090;

    myroute.to = new Address(); // new instance
    myroute.to.addressDescription = to;
    myroute.to.addressLatitude = 51.507335;
    myroute.to.addressLongitude = -0.127683;

    return View(myroute);
}

answered Feb 17, 2013 at 14:15

Darren

71.2k24 gold badges141 silver badges146 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

bas Over a year ago

@TrevorDaniel do you know that you can accept answers? There is a checkmark thingy next below the vote buttons. That way you can mark the question as answered. I noted that you did not accept any questions yet. Helps others from not having to read the Q&A for "solved questions". PS +1 for Darren for keeping me awake.:)

Mathew Thompson Over a year ago

@DarrenDavies back on the stack ;)

Darren Over a year ago

@mattytommo I'm an addict ;)

Mathew Thompson Over a year ago

@DarrenDavies +1 to you, you'll be 10k in no time ;)

bas · Accepted Answer · 2013-02-17 14:31:55Z

2

May I suggest to use the constructor to initialize the from and to fields? Otherwise you will have to new the objects every time you use the Route class.

public class Route
{
    public Address from { get; set; }
    public Address to { get; set; }

    public Route()
    {
        from = new Address();
        to = new Address();
    }
}

That way you can use your code as you provided:

    var myroute = new Route();

    myroute.from.addressDescription = from;
    myroute.from.addressLatitude = 51.481581;
    myroute.from.addressLongitude = -3.179090;
    myroute.to.addressDescription = to;
    myroute.to.addressLatitude = 51.507335;
    myroute.to.addressLongitude = -0.127683;

    return View(myroute);

edited Feb 17, 2013 at 14:31

answered Feb 17, 2013 at 14:22

bas

15.2k23 gold badges88 silver badges173 bronze badges

6 Comments

Darren Over a year ago

no it shouldn't contain quotes as from is a string. He is simply assigning addressDescription to this variable. The problem lies with that from and to had no instance of Address.

Darren Over a year ago

yeah I realise that but assigning addressDescription to "from" would not give the OP the correct output.

bas Over a year ago

I think that's exactly what he's trying to do, but lets not try to think for him. I'll remove the addition then.

Darren Over a year ago

why would he pass in a string called from containing the data if he wanted to assign it to the string literal "from"?

bas Over a year ago

I didn't say it was meaningful, but that's what the code example looks like.

|

Zbigniew · Accepted Answer · 2013-02-17 14:15:11Z

1

You have created Route instance, but you have forgotten to create new instances of Address (for from and to):

var myroute = new Route
{
    from = new Address(),
    to = new Address()
};

answered Feb 17, 2013 at 14:15

Zbigniew

27.6k6 gold badges62 silver badges68 bronze badges

Comments

Bhushan Firake · Accepted Answer · 2013-02-17 14:17:34Z

0

myroute.from and myroute.to shoud be an instance of Address class.

 public ActionResult FareCalculator(string from , string to)
 {
        var myroute = new Route();

        myroute.from = new Address();
        myroute.from.addressDescription = from;
        myroute.from.addressLatitude = 51.481581;
        myroute.from.addressLongitude = -3.179090;

        myroute.to = new Address();
        myroute.to.addressDescription = to;
        myroute.to.addressLatitude = 51.507335;
        myroute.to.addressLongitude = -0.127683;

        return View(myroute);
    }

answered Feb 17, 2013 at 14:17

Bhushan Firake

9,4825 gold badges47 silver badges79 bronze badges

Collectives™ on Stack Overflow

C# MVC Class Object reference not set to an instance of an object

4 Answers 4

4 Comments

6 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

6 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related