Unable to call javascript function from external.js file

Question

I am unable to call my javascript function named as clear which takes a string parameter the parameter value im passing by calling that function on client click. here is my code please do help me in this

<script type="text/javascript">       
    var _whichform = 'login'
    function clear(_whichform)
    {

        switch (_whichform)
        {
        case 'login':
               document.getElementById('<%=tbxUsername.ClientID%>').value = ''
               document.getElementById('<%=tbxPassword.ClientID%>').value = ''
               document.getElementById('<%=tbxFname.ClientID%>').value = ''
               document.getElementById('<%=tbxLname.ClientID%>').value = ''
               break;
          break;
         case 'company':
               document.getElementById('<%=tbxCompname.ClientID%>').value = ''
               document.getElementById('<%=tbxDescptn.ClientID%>').value = ''
               document.getElementById('<%=tbxCompanyEmail.ClientID%>').value = ''
               document.getElementById('<%=tbxStateCo.ClientID%>').value = ''
               document.getElementById('<%=tbxStateCo.ClientID%>').value = ''
               document.getElementById('<%=tbxCity.ClientID%>').value = ''
               document.getElementById('<%=tbxCompanyAddress.ClientID%>').value = ''
               document.getElementById('<%=tbxCpCountryCode.ClientID%>').value = ''
               document.getElementById('<%=tbxCpStateCode.ClientID%>').value = ''
               document.getElementById('<%=tbxPhone.ClientID%>').value = ''
               document.getElementById('<%=tbxCfCountryCode.ClientID%>').value = ''
               document.getElementById('<%=tbxCfStateCode.ClientID%>').value = ''
               document.getElementById('<%=tbxCffax.ClientID%>').value = ''
          break;

        }
    }
</script>
<input id="btnLoginCancel" type="button" value="Clear" onclick="clear('login')" class="buttons"/>

you have to use the 'Id' of the element there. Are you using JSP? — arjuncc
– arjuncc, Commented Feb 18, 2013 at 5:33
Do you know that in js you have to add a semicolon ; at the end of a code line? Also, you have two break statements in continues lines. — Lucio
– Lucio, Commented Feb 18, 2013 at 5:36
Maybe it could be useful the reset button for this case. <input type="reset" value="Reset" /> — Lucio
– Lucio, Commented Feb 18, 2013 at 5:39

martriay · Accepted Answer · 2013-02-18 05:32:26Z

2

You missed a semicolon.

var _whichform = 'login';

answered Feb 18, 2013 at 5:32

martriay

5,7423 gold badges32 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ajay_Dhama · Accepted Answer · 2013-02-18 09:58:16Z

0

There are few points needs your attention.

1. If this is the external JS file then you write it wrong, there is no need of writing <script type="text/javascript"></script> tags in external js file it throws the Syntax error. you can directly start from writing a function and be careful in calling js file (path etc.)

2. You missed semicolons at several places in your js file and there is no need of defining Var _whichform because you are already passing the parameter at the time of calling the function.

3. From Developers point of view it’s better to test your code on Firefox using firebug It certainly helps in debugging and writing better javascript code.

edited Feb 18, 2013 at 9:58

answered Feb 18, 2013 at 9:51

Ajay_Dhama

135 bronze badges

Comments

Vignesh Subramanian · Accepted Answer · 2013-12-27 09:26:38Z

0

You have missed a semicolon in the second line it should be var _whichform = 'login'; Also for testing and debugging its always better to use IE since it would have shown that you have missed the semicolon in your second line.

edited Dec 27, 2013 at 9:26

answered Feb 18, 2013 at 6:13

Vignesh Subramanian

7,31915 gold badges97 silver badges161 bronze badges

Comments

BenMorel · Accepted Answer · 2014-01-07 16:15:44Z

0

clear() is a native function in the browser. Name your function e.g. myclear, and it will work (provided the field with the id's named are correct).

clear is a method on window.document. In SOME browsers (e.g. chromium), the onclick will be executed in that context. This can be seen e.g. by adding onclick="console.log(clear)", and you will get something like: function clear() { [native code] }

Then it's always a good idea to end all statements with semicolon, to avoid later mixups with newlines etc.

edited Jan 7, 2014 at 16:15

BenMorel

37k52 gold badges208 silver badges339 bronze badges

answered Feb 18, 2013 at 5:40

fiddur

1,88717 silver badges12 bronze badges

5 Comments

Teemu Over a year ago

No conflict, clear is a method of document, not window.

fiddur Over a year ago

In the context of onclick on a html-element, clear is the native function. Try adding onclick="console.log(clear)" and it will state the navite function rather than the user specified.

Teemu Over a year ago

True, but when clicking the button (== window context), clear() is a user defined function, not a native function. EDIT This seems to vary in different browsers...

faruk mahir Over a year ago

i renamed it to myclear as you have suggested but it still not working

fiddur Over a year ago

If you have fixed all commented on here and it still doesn't work, the problem is not with the code presented. Make sure that the IDs are really inserted instead of the <% %>-code. If you see the <% in the source code on the html-page, your problem lies with your template engine, not the js itself. I have copied your code, (changed the name to myclear, added semicolons, removed the double break…) changed one of the IDs to 'test', added an input with id 'test', and it works well in both chromium and firefox.

Collectives™ on Stack Overflow

Unable to call javascript function from external.js file

4 Answers 4

Comments

Comments

Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related