AngularJS calling a controller from a directive

Question

I have a model called 'user', 'user' has a controller called 'login' and a directive called 'userMenu', what I'm trying to achieve is that the userMenu directive uses the controller 'login' that's available in the module. Maybe I don't understand well how the modules and directives should work but I'm doing the following:

First, I define my controller like this:

angular.module('user', []).
controller('login', ['$scope', '$http', function($scope, $http){
    $scope.logIn = function(){
        //Do something...
    }
}

Then, in my directive...

angular.module('user', []).
directive('userMenu', function(){
    return {
    priority: 0,
    templateUrl: 'app/includes/user/menu.html',
    replace: true,
    restrict: 'A',
    controller: 'login',
    }
});

But the I get this:

Error: Argument 'login' is not a function, got undefined

Would you please guide me on the use of directives and controllers within modules?

pkozlowski.opensource · Accepted Answer · 2013-02-18 13:38:38Z

3

The problem is that you are re-defining the user directive while preparing your directive. I presume that you wanted to register both a controller and a directive on the same module. If so you can register your directive like this:

angular.module('user').directive('userMenu', function(){
    return {
    ...
    }
});

Notice that there is no second argument ([]) to the call of angular.module which means that you want to retrieve an instance of already defined module instead of defining a new one.

answered Feb 18, 2013 at 13:38

pkozlowski.opensource

117k60 gold badges329 silver badges286 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

fixmycode Over a year ago

you were absolutely right, thanks! I didn't know that it was defining the module again :D

Collectives™ on Stack Overflow

AngularJS calling a controller from a directive

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related