PHP foreach loop inserting into database [closed]

Question

Closed. This question is not reproducible or was caused by typos. It is not currently accepting answers.

This question was caused by a typo or a problem that can no longer be reproduced. While similar questions may be on-topic here, this one was resolved in a way less likely to help future readers.

Closed 3 months ago.

Improve this question

I am trying to insert the selected values of checkboxes into a mysql database using php. I just can't understand why it's not working because it echoes out all the values fine, but it will only insert the first selected one into the database.

HTML:

<b>Injury type:</b>
Bruise <input type='checkbox' name='InjuryType[]' value='1'><br>
Cut <input type='checkbox' name='InjuryType[]' value='2'><br>
Graze <input type='checkbox' name='InjuryType[]' value='3'><br>
Break <input type='checkbox' name='InjuryType[]' value='4'><br>
Bump <input type='checkbox' name='InjuryType[]' value='5'><br>

PHP:

foreach($_POST['InjuryType'] as $value) {
$insert = mysql_query("INSERT INTO AccidentInjuryLink(InjuryID) VALUES ('$value')");
echo $value; 
}

1. Don't use the mysql driver, use PDO instead. This prevents SQL injections; I can also see that you're not escaping your posted values. 2. Maybe that column has a primary index which means all numbers must be unique, thus only inserting the first value. — silkfire
– silkfire, Commented Feb 21, 2013 at 20:01
Please, don't use mysql_* functions in new code. They are no longer maintained and are officially deprecated. See the red box? Learn about prepared statements instead, and use PDO or MySQLi - this article will help you decide which. If you choose PDO, here is a good tutorial. (Also, like silkfire said, you're vulnerable to SQL injection here, too.) — Cat
– Cat, Commented Feb 21, 2013 at 20:02
Your code is open to SQL injection attacks, here is a brief overview of what they are and how to prevent them. — Dan Simon
– Dan Simon, Commented Feb 21, 2013 at 20:02

silkfire · Accepted Answer · 2013-02-21 21:04:58Z

1

Maybe that column has a primary index which means all numbers must be unique, thus only inserting the first value.

answered Feb 21, 2013 at 21:04

silkfire

26.3k17 gold badges92 silver badges116 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

PHP foreach loop inserting into database [closed]

1 Answer 1

Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Related