Multiple string store in different variable C++

Question

This is my first time I post here so I'll try to be clear in my question. So I need to store different string with space in variable. I'm working with eclipse and I have a problem.

This is the code

using namespace std;
string p_theme;   
string p_titre;
int p_anneeEdition;
string p_pays;
string p_auteur;
string p_editeur;
string p_isbn;

cout << "Veuillez saisir le thème:" << endl;
getline(cin, p_theme, '\n');


cout << "Veuillez saisir le titre:" << endl;
getline(cin, p_titre, '\n');

....

This is what the console show to me

Veuillez saisir le thème:
Veuillez saisir le titre:

The problem is that I don't have the time to enter the string "Theme" before the second cout. I've tried different way, with a char buffer it didn't work i enter in a loop.

Welcome to SO. Your program should be a short self-contained compilable example, which makes things much easier. — Zeta
– Zeta, Commented Feb 21, 2013 at 21:47
@Nate: The answer covers formatted extraction on cin and getline. Here we use formatted output on cout, which shouldn't have any effect on a getline call on cin. — Zeta
– Zeta, Commented Feb 21, 2013 at 21:51
@Zeta: The answer covers getline(cin, ...) not waiting for user input, which seems to be exactly the problem reported here. I'm not sure which of us is misreading the question. — Nate Hekman
– Nate Hekman, Commented Feb 21, 2013 at 22:23

ipc · Accepted Answer · 2013-02-21 22:02:06Z

3

A getline which does nothing can have many reasons

A failbit was set (because reading of an int or similar has failed) in which case all calls to read from cin get ignored.
You have unread chars remaining on the input buffer. For example "\n" (which can be if you read a std::string with operator>>).

To handle both cases, insert

cin.clear();
cin.ignore(numeric_limits<streamsize>::max(), '\n');

before each call of getline (and add #include <limits> at the top of your file).

This is surely an overkill and if you are careful, this can be reduced.

Check each input if it succeeds (like int i; if (std::cin >> i) { /* ok */ })
Don't read a std::string without getline (for example operator>>), unless you later call cin.ignore(...).

If you do all this, the code should work as you already have it.

edited Feb 21, 2013 at 22:02

answered Feb 21, 2013 at 21:49

ipc

8,18331 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Zeta Over a year ago

cin.clear()? Why do you want to clear the error flags? Your current answer suggests that clear might clear the stream to someone who doesn't know istreams, who might then be confused why you ignore other values. Please elaborate.

ipc Over a year ago

@Zeta: I don't know the code before the getline in the posted question. Maybe a failbit was set (which would lead exactly to the behavior posted). If I would know the real code, not all of this is needed before every call of getline.

Collectives™ on Stack Overflow

Multiple string store in different variable C++

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related