MVC C# strange NullReference Exception

Question

I'm getting a bit of a strange error that has left me a bit baffled, so let me paint the picture:

I have a controller that updates the database with reviews on houses. If the house doesn't exist, it creates one and then updates it.

So this is the code for if the house doesn't exist:

if (checkHouse == null)
{
        var department = db.Universitys.Single(d => d.universityName == "NotSet");//make dynamic
        var hws = new House();
        hws.address1 = reviewmodelview.Address1;
        hws.address2 = reviewmodelview.Address2;
        hws.postCode = reviewmodelview.postCode;
        hws.noOfDisputes = 0;
        department.Houses.Add(hws);
        db.SaveChanges(); //created the house and saved the changes, now apply the review to it.

        var theHouse = db.Houses.Single(d => d.address1 == reviewmodelview.Address1);//findhouse
        var rvw = new Review(); //create review
        rvw.condition = reviewmodelview.condition;
        rvw.furniture = reviewmodelview.furniture;
        rvw.overall = reviewmodelview.overall;
        rvw.isApproved = false;
        rvw.review = reviewmodelview.review;
        rvw.user = User.Identity.Name;
        rvw.reviewDate = DateTime.Now;
        theHouse.Reviews.Add(rvw);
        db.SaveChanges();
}

and here's the code for if the house does exist:

else
{
    var theHouse = db.Houses.Single(d => d.address1 == reviewmodelview.Address1);//findhouse
    var rvw = new Review();//create review
    rvw.condition = reviewmodelview.condition;
    rvw.furniture = reviewmodelview.furniture;
    rvw.overall = reviewmodelview.overall;
    rvw.isApproved = false;
    rvw.review = reviewmodelview.review;
    rvw.user = User.Identity.Name;
    rvw.reviewDate = DateTime.Now;
    theHouse.Reviews.Add(rvw);
    db.SaveChanges();
}

Now the problem is this, if the house exists, the review is added. If the house doesn't exist, the house is added to the database but the code breaks at:

theHouse.Reviews.Add(rvw);

And if I hover my mouse over Reviews it says that its null. The error is "Object reference not set to an instance of an object."

However, if I then try again but this time add the address of a house that already exists on the database and add a breakpoint at

theHouse.Reviews.Add(rvw);

it says: {System.Data.Objects.DataClasses.EntityCollection<Data.Manager.Review>}

I can't figure out why the review collection is null for what are two identical pieces of code!

The house model is this:

namespace Data.Manager
{
    public class House
    {
        public virtual int HouseID { get; set; }
        public virtual string postCode { get; set; }
        public virtual string address1 { get; set; }
        public virtual string address2 { get; set; }
        public virtual int noOfDisputes { get; set; } //number of disputes added by tennants
        public virtual int averageRating { get; set; }
        public virtual ICollection<Review> Reviews { get; set; }        
    }
}

If I could get an explanation as to why this is happening, I'd love you forever.

Ant P · Accepted Answer · 2013-02-22 19:51:33Z

6

If you're creating a new house with ICollection<Review> Reviews, you will have to initialize that before you can use Reviews.Add. The reason it will work for a house that already exists will be because, when you load an existing house, the collection will be initialized and populated with the existing values.

You will have to do something along the lines of theHouse.Reviews = new List<Review>(); before you can call theHouse.Reviews.Add. You could also initialize this in advance within the constructor for House, to ensure that it is initialized prior to any access attempts.

edited Feb 22, 2013 at 19:51

answered Feb 22, 2013 at 15:47

Ant P

25.3k8 gold badges74 silver badges109 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

AndrewR · Accepted Answer · 2013-02-22 16:13:09Z

2

Try to initialize your collection of Reviews like this in House constructor

namespace Data.Manager
{
    public class House
    {
        public House()
        {
          Reviews = new List<Review>();
        }

        public virtual int HouseID { get; set; }
        public virtual string postCode { get; set; }
        public virtual string address1 { get; set; }
        public virtual string address2 { get; set; }
        public virtual int noOfDisputes { get; set; } //number of disputes added by tennants
        public virtual int averageRating { get; set; }
        public virtual ICollection<Review> Reviews { get; set; }        
    }
}

edited Feb 22, 2013 at 16:13

AndrewR

6,7681 gold badge26 silver badges38 bronze badges

answered Feb 22, 2013 at 15:57

Muammer HALLAC

1731 silver badge7 bronze badges

Comments

AndrewR · Accepted Answer · 2013-02-22 15:56:05Z

0

As the previous answer states, you need to initialize the Reviews object before adding items to it.

You can make your code slightly better by only saving the changes one time instead of making two calls to the DB.

        if (checkHouse == null)
        {

            var department = db.Universitys.Single(d => d.universityName == "NotSet");//make dynamic
            var hws = new House();
            hws.address1 = reviewmodelview.Address1;
            hws.address2 = reviewmodelview.Address2;
            hws.postCode = reviewmodelview.postCode;
            hws.noOfDisputes = 0;
            hws.Reviews = new List<Review>();

            var rvw = new Review(); //create review
            rvw.condition = reviewmodelview.condition;
            rvw.furniture = reviewmodelview.furniture;
            rvw.overall = reviewmodelview.overall;
            rvw.isApproved = false;
            rvw.review = reviewmodelview.review;
            rvw.user = User.Identity.Name;
            rvw.reviewDate = DateTime.Now;
            hws.Reviews.Add(rvw);
            department.Houses.Add(hws);

            db.SaveChanges();

        }

answered Feb 22, 2013 at 15:56

AndrewR

6,7681 gold badge26 silver badges38 bronze badges

1 Comment

Jay Over a year ago

Ah I see, I added that additional savechanges because I thought that was the problem to begin with. I'll take it out. Thanks both

Collectives™ on Stack Overflow

MVC C# strange NullReference Exception

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related