I have a List which is returned to me from a 3rd party. Each string in the list ends in "mph" and I would like to remove the "mph". The obvious answer is to foreach over the list but I didn't know if there was a more efficient way to do it.
Thanks.
-
3one way or other, you have to perform a iteration!Parimal Raj– Parimal Raj2013-02-23 17:07:58 +00:00Commented Feb 23, 2013 at 17:07
Add a comment
|
7 Answers
in a word, no. Something has to pass over the list in order to modify it. A for loop is probably the most efficient way though not necessarily the most concise
Comments
You have to iterate over the list to touch each item and make a change.
The easiest way to do this is via linq:
var originallist = new List<string> { "50mph", "35mph", "100mph" };
var newlist = list.Select(s => s.Substring(0, s.Length - 3));
Comments
You can use LINQ instead of a foreach loop:
list.Select( s => s.Substring(0, s.Length - 3) )
5 Comments
Andrew Mao
It certainly does exist: msdn.microsoft.com/en-us/library/bwabdf9z.aspx, but I was just thinking of the wrong function. Fixed.
Andrew Mao
Yes, if strings weren't immutable that might be more efficient for many types of operations. But see this article: blogs.msdn.com/b/ericlippert/archive/2009/05/18/…
andri
@AndrewMao: IMHO, less code to write is also a kind of "efficiency" :)
you can use LINQ for that purpose. Something like this might works :
var noMph = theList.Select(p => p.Replace("mph", "").ToList();
Simple Answer : You Can't
One way or another you have to perform a iteration.
it may be :
foreach
for
List.ForEach
Comments
Well you can write
mylist.Select(s=>s.Substring(0, s.Length-3));//Can add .ToList() here
But that is using a loop. You don't have to write the foreach at least :)
2 Comments
Andrew Mao
Also fix the
substring to Substring :)this will work
List<string> newList = new List<string>();
mylist.ForEach((item)=>
{
item=item.Replace("mph","");
newlist.Add(item);
});
